hi3516ev300 / gk7205v300: exclude the renamed IMX335 profiles - #169
Merged
Merged
Conversation
OpenIPC/firmware#2482 renames the IMX335 profiles on the 128 MB parts: imx335_i2c_4M.ini becomes 4M_imx335_i2c.ini and 5M_imx335.ini becomes imx335_i2c_5M.ini, with 5M_imx335.ini kept as a link. The exclude lists of the three devices on those parts now name the new files, so the two ev300 devices without an IMX335 keep dropping them. The 64 MB parts keep the old names and need nothing.
openipc-ai
requested review from
cronyx,
flyrouter and
viktorxda
as code owners
September 26, 2026 11:45
PR Summary by QodoAlign IMX335 exclusions with renamed 128 MB profiles
AI Description
Diagram
High-Level Assessment
Files changed (3)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can type 'qodo, fix this' on a finding and the fix lands right on your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenIPC/firmware#2482 makes 5 MP the IMX335 default on the 128 MB parts (hi3516ev300, hi3516dv200, gk7205v300, gk7605v100) by renaming the profiles there:
imx335_i2c_4M.ini→4M_imx335_i2c.ini5M_imx335.ini→imx335_i2c_5M.ini, with5M_imx335.inikept as a linkThis updates the exclude lists of the three builder devices on those parts:
hi3516ev300_ultimate_rostelecom-ipc8232swc-wehi3516ev300_ultimate_rvi-1ncmw2028gk7205v300_lite_vixand-ivg-g6s-w(its entries are commented out; updated so they stay accurate)The two ev300 devices have no IMX335, and keep dropping all its profiles. The other 17 devices that name these files are on 64 MB parts, which keep the old names, so they are untouched.
Merge after OpenIPC/firmware#2482. Until then these lists name files the firmware does not ship yet, and the old names would be left in the image.