Skip to content

hi3516ev300 / gk7205v300: exclude the renamed IMX335 profiles - #169

Merged
openipc-ai merged 1 commit into
masterfrom
imx335-5m-rename
Sep 26, 2026
Merged

openipc-ai merged 1 commit into
masterfrom
imx335-5m-rename

Conversation

@openipc-ai

Copy link
Copy Markdown
Contributor

OpenIPC/firmware#2482 makes 5 MP the IMX335 default on the 128 MB parts (hi3516ev300, hi3516dv200, gk7205v300, gk7605v100) by renaming the profiles there:

  • imx335_i2c_4M.ini → 4M_imx335_i2c.ini
  • 5M_imx335.ini → imx335_i2c_5M.ini, with 5M_imx335.ini kept as a link

This updates the exclude lists of the three builder devices on those parts:

  • hi3516ev300_ultimate_rostelecom-ipc8232swc-we
  • hi3516ev300_ultimate_rvi-1ncmw2028
  • gk7205v300_lite_vixand-ivg-g6s-w (its entries are commented out; updated so they stay accurate)

The two ev300 devices have no IMX335, and keep dropping all its profiles. The other 17 devices that name these files are on 64 MB parts, which keep the old names, so they are untouched.

Merge after OpenIPC/firmware#2482. Until then these lists name files the firmware does not ship yet, and the old names would be left in the image.

OpenIPC/firmware#2482 renames the IMX335 profiles on the 128 MB parts:
imx335_i2c_4M.ini becomes 4M_imx335_i2c.ini and 5M_imx335.ini becomes
imx335_i2c_5M.ini, with 5M_imx335.ini kept as a link. The exclude lists
of the three devices on those parts now name the new files, so the two
ev300 devices without an IMX335 keep dropping them. The 64 MB parts keep
the old names and need nothing.
@qodo-free-for-open-source-projects

Copy link
Copy Markdown

PR Summary by Qodo

Align IMX335 exclusions with renamed 128 MB profiles

⚙️ Configuration changes 🐞 Bug fix 🕐 Less than 10 minutes

Grey Divider

AI Description

• Aligns three 128 MB device lists with renamed IMX335 profiles.
• Preserves complete IMX335 removal from two unsupported EV300 devices.
• Keeps commented GK7205V300 exclusions accurate without changing behavior.
Diagram

graph TD
  F["128 MB firmware"] --> P["Renamed profiles"] --> R["Rostelecom list"] --> E["EV300 images"]
  P --> V["RVI list"] --> E
  P --> G["Vixand list"]
Loading
High-Level Assessment

Updating only the device-scoped lists on affected 128 MB parts is the safest approach. It preserves explicit exclusions and avoids broad wildcard rules that could remove valid profiles or unintentionally affect 64 MB devices retaining the old names; merge ordering with OpenIPC/firmware#2482 must be maintained.

Files changed (3) +12 / -6

Bug fix (2) +8 / -4
hi3516ev300_ultimate.listExclude renamed IMX335 profiles from Rostelecom image +4/-2

Exclude renamed IMX335 profiles from Rostelecom image

• Adds the renamed 5 MP profile and updates normal and WDR 4 MP paths. Both retained aliases and renamed profiles remain excluded from this device without IMX335 support.

devices/hi3516ev300_ultimate_rostelecom-ipc8232swc-we/general/scripts/excludes/hi3516ev300_ultimate.list

hi3516ev300_ultimate.listExclude renamed IMX335 profiles from RVI image +4/-2

Exclude renamed IMX335 profiles from RVI image

• Adds the renamed 5 MP profile and updates normal and WDR 4 MP paths. This keeps all IMX335 profiles out of the unsupported EV300 device image after the firmware rename.

devices/hi3516ev300_ultimate_rvi-1ncmw2028/general/scripts/excludes/hi3516ev300_ultimate.list

Other (1) +4 / -2
gk7205v300_lite.listRefresh commented IMX335 profile exclusions +4/-2

Refresh commented IMX335 profile exclusions

• Adds the renamed 5 MP profile and replaces 4 MP paths with their new names in the normal and WDR sections. Entries remain commented, so device image filtering behavior is unchanged.

devices/gk7205v300_lite_vixand-ivg-g6s-w/general/scripts/excludes/gk7205v300_lite.list

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can type 'qodo, fix this' on a finding and the fix lands right on your PR

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@openipc-ai
openipc-ai merged commit f4dcd25 into master Sep 26, 2026
8 checks passed
@openipc-ai
openipc-ai deleted the imx335-5m-rename branch September 26, 2026 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant