Conversation
Keep renderer implementation tests in build-infra and make the schema workflow run only the repository-owned schema suite when it is present. Co-authored-by: Codex <codex@openai.com>
handrews
marked this pull request as draft
October 2, 2026 17:08
Member
Author
|
Something else is needed here to get the tests from the build-infra package to run. And of course linkspector is confused again, even though every single link it complains about is fine. Why do we use this thing? It's been nothing but pain. |
Member
Author
|
A new version of this will get posted after OAI/build-infra#65 is merged and released. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bit of missed clean-up from the build-infra migration. Note that we are keeping scripts in
tests/schemabecause those are custom per repository. The md2html tests are shared and already supported by build-infra.Keep renderer implementation tests in build-infra and make the schema workflow run only the repository-owned schema suite when it is present.
Commit
ee45561c:tests/md2htmltree.tests/schema/schema.test.mjsexplicitly when present.main, where that runner is intentionally absent.CONTRIBUTING.mdto describeyarn testas the development-branch schema suite.Verification:
Markdown and link validation passed.
The explicit command ran all 20
devschema tests successfully.Workflow YAML and Git diffs passed validation.
ReSpec’s local browser launch failed due to the execution environment; it reached the build step and is unrelated to this cleanup.
Working tree is clean. Nothing was pushed.
schema changes are included in this pull request
schema changes are needed for this pull request but not done yet
no schema changes are needed for this pull request