feature/CSTACKEX-310: implement all method for ontap iscsi adapter - #105
Merged
Merged
Conversation
…d removed changes from common iscsiadmstorageadpater
🔴 Test Coverage Grade:
|
| Metric | Value |
|---|---|
| Line coverage | 24.73% |
| Branch coverage | 18.86% |
Grade Scale
| Grade | Line Coverage | Meaning |
|---|---|---|
| 🟢 A | ≥ 80% | Excellent - this code sleeps well at night 😴 |
| 🟡 B | 60-79% | Good - almost there, don't stop now 😉 |
| 🟠 C | 40-59% | Acceptable - your code is wearing a seatbelt, but no airbags 😬 |
| 🔴 D | 20-39% | Marginal - boldly shipping where no test has gone before 🖖 |
| ⛔ F | < 20% | Failing - tests? what tests? 🔥 |
Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run
🔴 Test Coverage Grade:
|
| Metric | Value |
|---|---|
| Line coverage | 24.73% |
| Branch coverage | 18.87% |
Grade Scale
| Grade | Line Coverage | Meaning |
|---|---|---|
| 🟢 A | ≥ 80% | Excellent - this code sleeps well at night 😴 |
| 🟡 B | 60-79% | Good - almost there, don't stop now 😉 |
| 🟠 C | 40-59% | Acceptable - your code is wearing a seatbelt, but no airbags 😬 |
| 🔴 D | 20-39% | Marginal - boldly shipping where no test has gone before 🖖 |
| ⛔ F | < 20% | Failing - tests? what tests? 🔥 |
Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run
piyush5netapp
requested review from
rajiv-jain-netapp,
sandeeplocharla and
suryag1201
September 17, 2026 11:16
rajiv-jain-netapp
left a comment
rajiv-jain-netapp
left a comment
There was a problem hiding this comment.
can you add testing results
Author
@rajiv-jain-netapp Testing result are added in description. Oracle linux is not tested for this change as its copy paste changes. |
rajiv-jain-netapp
approved these changes
Oct 1, 2026
suryag1201
approved these changes
Oct 1, 2026
sandeeplocharla
approved these changes
Oct 1, 2026
piyush5netapp
added
the
to-be-cherry-picked-for-upstream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…d removed changes from common iscsiadmstorageadpater
Description
This PR...
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Tested happy path testing in ubunut VM. All workflows working fine.
Create zone->Pod-> Cluster->Host->Primary Storage->Secondary Storage.
iSCSI
Create Storage Pool - PASS
Create disk and compute offering for the storage pool using only the tag. - PASS
Create VM instance using the same disk and compute offering. - PASS
Power Off the VM. - PASS
Power on the VM on the same host again. - PASS
Destroy the VM without expunge and no data volume selected. - PASS
Attach the disk/volume to a already running VM. - PASS
Detach the disk/volume from a running VM. - PASS
Destroy the volume without expunge. - PASS
Recover the destroyed volume again. - PASS
Destroy the VM without expunge and all data volume selected.- PASS
Destroy the VM with expunge and all data volume selected.- PASS
Take instance snapshot without quiesce and without memory.- PASS
How did you try to break this feature and the system with this change?