Always email developers when they make a plugin sale - #542
Merged
Merged
Conversation
PluginSaleCompleted wasn't marked as transactional, so developers who had turned off email notifications, or who hadn't verified their email address, never got the sale email. They only saw the in-app notification. It now implements TransactionalNotification, like the purchase receipt, so the email is sent regardless of those settings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PluginSaleCompletedwasn't marked as transactional, soSuppressMailNotificationListenerdropped the email for developers who had turned off email notifications in their settings, or whose email address wasn't verified. Those developers only saw the in-app notification.It now implements
TransactionalNotification, likePurchaseReceiptand the license emails, so the sale email goes out regardless of those settings.Please check you're happy with the unverified case. Sale emails will now go to addresses nobody has confirmed. The other transactional emails already do this.
I added two tests to
PluginSaleCompletedTest, one for a developer who opted out and one with an unverified email. Both fail without the change.🤖 Generated with Claude Code