fix(windows): restore MXC MSVC builds - #3488
Merged
Merged
Conversation
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
drew
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 20, 2026 03:40
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore the advisory Windows MSVC x64 and ARM64 lanes after two MXC compile regressions reached main.
Related Issue
No issue required: this is a localized compilation repair for existing CI coverage.
Changes
namefieldopenshell-policya normal MXC dependency because production policy mapping calls its enum helpersTesting
cargo check -p openshell-driver-mxc --libcargo test -p openshell-driver-mxccargo clippy -p openshell-driver-mxc --all-targets -- -D warningsmise run pre-commitBoth native Windows architectures pass the full PR lint and test jobs. The seed-cache and binary-build jobs run only on
mainor manual dispatch and exercise the same corrected Windows-supported workspace compilation.Checklist