Skip to content

fix(windows): restore MXC MSVC builds - #3488

Merged
drew merged 3 commits into
mainfrom
codex/fix-windows-mxc-drift/drew
Sep 20, 2026
Merged

drew merged 3 commits into
mainfrom
codex/fix-windows-mxc-drift/drew

Conversation

@drew

@drew drew commented Sep 20, 2026

Copy link
Copy Markdown
Collaborator

Summary

Restore the advisory Windows MSVC x64 and ARM64 lanes after two MXC compile regressions reached main.

Related Issue

No issue required: this is a localized compilation repair for existing CI coverage.

Changes

  • update the MXC gRPC adapter to use the canonical compute-driver request name field
  • make openshell-policy a normal MXC dependency because production policy mapping calls its enum helpers
  • resolve Windows-only Clippy diagnostics, retaining a targeted allowance for the test that intentionally covers the legacy TLS enum variant

Testing

  • cargo check -p openshell-driver-mxc --lib
  • cargo test -p openshell-driver-mxc
  • cargo clippy -p openshell-driver-mxc --all-targets -- -D warnings
  • mise run pre-commit
  • Windows MSVC x64 and ARM64 lint and test

Both native Windows architectures pass the full PR lint and test jobs. The seed-cache and binary-build jobs run only on main or manual dispatch and exercise the same corrected Windows-supported workspace compilation.

Checklist

  • The changes are scoped to the Windows MXC compilation failures
  • Conventional commits with DCO sign-off
  • Relevant local checks pass
  • Native Windows x64 and ARM64 checks pass

Signed-off-by: Drew Newberry <anewberry@nvidia.com>
@drew drew added the test:windows Run native Windows x64 and ARM64 lint/tests on PR mirrors label Sep 20, 2026
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
@drew
drew merged commit 29e89a2 into main Sep 20, 2026
60 checks passed
@drew
drew deleted the codex/fix-windows-mxc-drift/drew branch September 20, 2026 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test:windows Run native Windows x64 and ARM64 lint/tests on PR mirrors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant