Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Serialize common chat/completion SSE deltas directly, coalesce events at PD batch boundaries, and cache per-stream tool metadata. Keep event ordering, tool arguments, logprobs/echo and usage unchanged; flush buffered output before stream errors.
Also avoid per-message receive tasks and allocating a fake token list solely for length validation. These remove CPU work on the streaming path without waiting for the next model token to flush a completed batch.
This covers only the remaining optimizations; compact forwarding stays in #1486 and #1487 (the latter needs rebasing for main's updated ObjType values). Tests: streaming/API and PD regressions (79 passed).