Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject oversized UTF-8 JSON schemas with a validation error and require the xgrammar backend when grammar or JSON constraints are requested. Tokenizer wrappers explicitly expose their underlying HF text tokenizer to validation and inference.
This avoids assertion failures, requests that succeed without enforcing their constraints, and xgrammar type-check failures on wrapped tokenizers. Constraints are never silently dropped.
Tests: schema boundaries, backend validation and real xgrammar compilation with wrapped HF tokenizers (19 passed).