Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into a build failure when building
plugin_pythonwithRelWithDebInfo:CMake also reported CMP0111 warnings for
Python::ModuleandPython::Python, indicating that their imported locations were not available for theRelWithDebInfoconfiguration.The existing code temporarily clears
CMAKE_MAP_IMPORTED_CONFIG_*before callingfind_package(Python). This change usesunset()instead of assigning an empty string, so those variables are not defined while the Python imported targets are created.With this change, the
plugin_pythonbuild succeeds in my environment.Tested with:
RelWithDebInfoI'm not sure whether this affects other CMake/Python combinations, but this seems to better match the intent of temporarily disabling the imported configuration mappings.