Repository navigation
Make password reset tokens single-use - #687
Merged
Merged
Conversation
Bind each token to a random nonce stored on the user. Requesting a reset rotates the nonce, revoking older links; any password change clears it, so a link works once and dies on a logged-in password change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Coverage Report for CI Build 36836952244Coverage increased (+0.02%) to 92.689%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions16 previously-covered lines in 2 files lost coverage.
Coverage Stats
💛 - Coveralls |
MarcelGeo
requested changes
Sep 30, 2026
MarcelGeo
left a comment
MarcelGeo
left a comment
Collaborator
There was a problem hiding this comment.
As I understand old tokens will be revoked, no?
Collaborator
Author
Yes, on purpose. Old link will get invalid token and user can just create a new one. Old links are valid only for 1 hour anyway so the impact is very low. |
MarcelGeo
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bind each token to a random nonce stored on the user. Requesting a reset rotates the nonce, revoking older links; any password change clears it, so a link works once and dies on a logged-in password change.
There is also a new config variable
PASSWORD_RESET_TOKEN_EXPIRATION.