Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the server sends an ErrorResponse and then closes the connection without a ReadyForQuery, the error was dropped. The waiter only got a generic
ConnectionDoesNotExistError. This happens with pgbouncer'squery_wait_timeoutand with any FATAL such aspg_terminate_backend()._handle_waiter_on_connection_lostnow checks for a pending failed result. The exception type staysConnectionDoesNotExistErrorso existing handlers keep working. The server message is appended and thePostgresErroris set as__cause__:Tested with a new test that terminates a backend mid-query. It fails on master and passes with the fix. I also checked the pgbouncer case against a small fake server that sends
FATAL 08P01 query_wait_timeoutand closes. The full suite passes on PostgreSQL 15 apart from the GSSAPI tests, which need Kerberos binaries I didn't have locally.Fixes #1299