Conversation
elprans
added a commit
that referenced
this pull request
Sep 20, 2026
An `ErrorResponse` to `SSLRequest` is currently reported as an SSL refusal, while transport fallback only handles a narrow set of authorization errors. Follow libpq transport-selection behavior and improve the SSL exchange diagnostic without trusting pre-TLS server text or exposing SQLSTATE (see CVE-2024-10977). Make it so that alternative transports in allow/prefer retries are only tried _before_ authentication succeeds, not after. While here, align asyncpg with libpq and require `ssl` to be set to a mandatory TLS mode (or explicit context) when `direct_tls` is specified. Fixes #1317. Closes #1346. Closes #1348.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve the PostgreSQL server's diagnostic when it returns an early error while asyncpg is waiting for the one-byte SSL negotiation response.
Changes
ErrorResponsemarker (E)InterfaceErrorS, advisoryN, and generic fallback behaviorTest plan
python -m unittest tests.test_connect.TestTLSUpgradeProto.test_error_response_preserves_server_messageFixes #1317