refactor(http_fetcher): make dynamic URL handling explicit - #4282
Merged
Merged
Conversation
khassel
approved these changes
Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4278, which introduced support for dynamic URLs in
HTTPFetcher.That support was added as an implicit
string | functionconstructor argument. This works, but is not very explicit at the call site. This PR cleans that up by using{ url }for static URLs and{ urlFactory }for URLs that are resolved for each request.This also simplifies the
envcanadaprovider. It previously had to track the current hour and restart the fetcher whenever the hourly URL changed. It now uses the resolved request URL to detect and ignore stale responses, without restarting the fetcher.