PoC: Using wp_kses to allow-list expected markup - #237
Draft
matt-bernhardt wants to merge 2 commits into
Draft
matt-bernhardt wants to merge 2 commits into
matt-bernhardt wants to merge 2 commits into
Conversation
1 of 13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This shows how we can use
wp_kses()to allowlist specific markup, while dropping everything we don't want/support/expect. There are three parts:$allowed_htmlwith two things: an anchor tag, and an href attribute. If we expected more complex markup (class or rel attributes, for example), we would add those entries.wp_kses()to the existingechostatement, supplying 1. the variable to be rendered, and the$allowed_htmlarray that defines what is allowed to pass through.phpcs:disablecall, because the constraint is now satisfied.I've found this a helpful strategy for small pieces of content where we know there will be markup present, but that markup is extremely limited. It wouldn't be as good a fit for something like
echo $page_bodybecause there is a nearly unlimited amount of markup that might be present on some page, so the allowlist would be unworkably large.