Conversation
Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
…de snippets Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
YvesCesar
marked this pull request as draft
September 28, 2026 15:53
…ares Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
vitormattos
requested changes
Sep 29, 2026
| <!-- wp:post-template {"className":"products-block-post-template","layout":{"type":"grid","columnCount":5},"__woocommerceNamespace":"woocommerce/product-query/product-template"} --> | ||
| <!-- wp:woocommerce/product-image {"isDescendentOfQueryLoop":true} /--> | ||
|
|
||
| <!-- wp:post-title {"textAlign":"center","level":3,"fontSize":"medium","__woocommerceNamespace":"woocommerce/product-query/product-title"} /--> |
Member
There was a problem hiding this comment.
The related product title is not clickable here because core/post-title does not have isLink: true.
Could we keep the product title linked, as we already do in the product catalog?
Suggested change
| <!-- wp:post-title {"textAlign":"center","level":3,"fontSize":"medium","__woocommerceNamespace":"woocommerce/product-query/product-title"} /--> | |
| <!-- wp:post-title {"textAlign":"center","level":3,"isLink":true,"fontSize":"medium","__woocommerceNamespace":"woocommerce/product-query/product-title"} /--> |
| <main class="wp-block-group"> | ||
| <!-- wp:woocommerce/breadcrumbs /--> | ||
| <!-- wp:woocommerce/store-notices /--> | ||
| <main class="wp-block-group"><!-- wp:woocommerce/store-notices /--> |
Member
There was a problem hiding this comment.
why does we removed the indent here?
Comment on lines
+26
to
+27
| wp_enqueue_style( 'bootstrap-css', 'https://cdn.jsdelivr.net/npm/bootstrap@5.3.0/dist/css/bootstrap-grid.min.css', array(), '5.3.0' ); | ||
| wp_enqueue_style( 'lineicons', 'https://cdn.lineicons.com/4.0/lineicons.css', array(), null ); |
Member
There was a problem hiding this comment.
Can we remove the CDN dependency here and manage these packages through package.json instead?
This would make the frontend dependencies versioned and reproducible, without relying on external CDNs at runtime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of what the theme shows was saved in the database instead of in this repository: the Global Styles, five templates edited in the Site Editor, and three Code Snippets. On a fresh install, such as CI or a test environment, the theme rendered without the brand colors, with a different header, and with an empty footer, because
parts/footer.htmlpoints to alibresign/footerpattern that does not exist. This moves that state into the theme, so activating it is enough to get the same site.Changes
theme.json: the three brand colors (custom-brand-1tocustom-brand-3, same slugs so everyvar(--wp--preset--color--custom-brand-*)keeps working), the button background, the heading color and weight, the navigation link weight, and the 1024px content width. The Global Styles also replaced the theme font list with one without Cardo, which left theheadingfont undefined and made headings inherit their font; Cardo is removed fromtheme.json, and the heading element, the quote and pullquote styles and five patterns no longer ask for theheadingfont, which keeps that inheritance. The Cardo files stay, the style variations use them.parts/header.html,parts/footer.html,templates/archive-product.html,templates/single-product.htmlandtemplates/coming-soon.htmlnow hold what the Site Editor had saved. The header menu pointed to awp_navigationpost by id (ref: 57); its links are now inside the navigation block. Three things that came with the saved copies are corrected on the way:libresign/related-products) with the same markup and the heading throughesc_html_e( 'Related products', 'woocommerce' ), so pt_BR shows "Produtos relacionados". The WooCommerce related products pattern was not used because it renders a different layout.inc/assets.phpwith the same handles, and the CSS of "Header and footer styling" isassets/css/header-footer.css. The header and footer fragments from the static site use the Bootstrap grid and theud-*classes, so they are still needed. With the same handles, a site where the snippets are still active does not load them twice./privacy-police/also returns 404. They now link tohttps://libresign.coop/privacy-policy, the policy the footer and the static site link to.After deploy
Until the database copies are removed, they keep taking precedence and the site looks the same. To make the theme the only source:
Verification
Full-page screenshots of the home,
/lost-password/, the store, the cart, two product pages and a 404, as guest and as admin, at 1280px and 390px wide (28 screenshots), compared pixel by pixel:main: all 28 are identical, and Bootstrap, LineIcons and the header and footer CSS load once.mainwith them: identical with and without the synced header and footer fragments, except the WooCommerce "coming soon" page shown to guests: the Facebook icon is gone, and the heading font changed. WooCommerce registers the Cardo font for that page only when the theme does not declare a font named Cardo; the theme declared it without using it, so the page fell back to a generic serif. It now renders in Cardo, as the WooCommerce template intends.composer cipasses.