Skip to content

[#583] Update links for the /links command (TK) - #584

Closed
mbti0n wants to merge 14 commits into
KnightHacks:mainfrom
mbti0n:main
Closed

mbti0n wants to merge 14 commits into
KnightHacks:mainfrom
mbti0n:main

Conversation

@mbti0n

@mbti0n mbti0n commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

Why

The /links command from the TK bot currently contains links from previous Knight Hacks events and pages from 2024; for instance, Knight Hacks VII instead of the upcoming Knight Hacks IX.

What

Updated links for the /links command, including:

  • Knight Hacks IX website
  • Removed the link for Kickstart Mentee Application as it was already closed
  • Blade website, combining the old due paying website and the membership Google Form

Screenshot

image

Test Plan

Ran the Discord bot on a burner server and tested the /links command. Ran all required pnpm commands and passed all tests.

Checklist

  • Database: No schema changes, OR I ran pnpm db:generate and committed the generated files in packages/db/drizzle/
  • Environment Variables: No environment variables changed, OR I have contacted the Development Lead to modify them on Coolify BEFORE merging.

@coderabbitai

coderabbitai Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

📝 Walkthrough

Walkthrough

The LINKS entries now point to KnightHacks IX registration and the dues page. The previous KnightHacks VII registration, dues payment, membership form, and Kickstart mentee links were removed.

Priority: ⬇️ Low

Merge Risk: 🔵 Low · up to b2693

The dues link currently opens a general membership page rather than the payment flow. Point it to the dues page before relying on /links to take members directly to payment.

🚥 Pre-merge checks | ✅ 8
✅ Passed checks (8 passed)
Check name Status Explanation
Title check ✅ Passed The title starts with issue number [#583], describes the /links command update, and is 47 characters long.
Description check ✅ Passed The description explains the outdated links, the replacements, and the reported testing for the /links command.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No Hardcoded Secrets ✅ Passed The PR changes only public URLs and link labels in apps/tk/src/consts/index.ts. No API key, password, token, or secret literal was added.
Validated Env Access ✅ Passed The pull request changes only apps/tk/src/consts/index.ts. The diff adds link strings and contains no process.env usage.
No Typescript Escape Hatches ✅ Passed The pull request changes only string values in apps/tk/src/consts/index.ts. The diff introduces no any, @ts-ignore, @ts-expect-error, or non-null assertion (!.) usage.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

Quiet mode is enabled, so only the most important comments were posted inline. Other review comments are grouped below.

🟡 Other comments (1)
apps/tk/src/consts/index.ts-53-53 (1)

53-53: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Link directly to the dues page.

/links labels https://blade.knighthacks.org/ as “pay your dues here,” but the root URL renders Blade’s general membership landing page. The dues flow is at /member/dues.

Suggested fix
-  "• [**Be a member and pay your dues here!**](https://blade.knighthacks.org/)",
+  "• [**Be a member and pay your dues here!**](https://blade.knighthacks.org/member/dues)",

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository: KnightHacks/forge/.coderabbit.yml

Review profile: QUIET

Plan: Advanced

Run ID: b711e2e0-755b-4f45-b5ba-08290d7151f6

📥 Commits

Reviewing files that changed from the base of the PR and between 99a8718 and b269393.

📒 Files selected for processing (1)
  • apps/tk/src/consts/index.ts

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@must108 must108 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is the screenshot black and white? lol

also please update your branch there are some old commits in here

@mbti0n

mbti0n commented Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

Wdym by black and white? You mean the color of the screenshot is not saturated?

Also I already synced all possible commits to my branch. Idk if that's how the "sync fork" button works.

@must108 must108 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fine but please squash ur commits

also yeah doesnt look saturated or something

@mbti0n

mbti0n commented Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

Gotcha. Also I lowered the UI saturation on purpose cuz I wanted a less distracting Discord experience.

@mbti0n

mbti0n commented Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

Replaced by #591, which is based on the latest upstream main and contains only the /links change.

@mbti0n mbti0n closed this Oct 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants