fix: visit expressions in macro, assertion and export statement output - #2663
Merged
manticore-projects merged 1 commit intoSep 21, 2026
Conversation
Signed-off-by: minleejae <mmj9808@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StatementDeParser currently bypasses its configured visitors when emitting CREATE MACRO, ASSERT and EXPORT DATA. For example, a custom ExpressionDeParser that rewrites numeric literals sees neither a macro's default/body nor the SELECT inside EXPORT DATA, even though these are already structured AST nodes.
Add renderer overloads to the statements' appendTo methods and connect them to the configured expression/select visitors. Existing appendTo/toString methods reuse the same punctuation. This covers macro parameter defaults, scalar/table bodies, ASSERT conditions/descriptions and EXPORT options/queries, including CTEs and UNIONs.
This is an output traversal fix for existing ASTs. The regression tests assert which values are visited and the rewritten SQL, alongside default-output round trips. BigQuery and DuckDB server execution was not performed.
References: DuckDB CREATE MACRO, BigQuery ASSERT, EXPORT DATA.
Validation:
checkpassed on Java 17, including grammar ambiguity, formatting, static analysis, coverage and the full test suite. JUnit XML totals: 7817 tests, 0 failures/errors, 25 skipped.