feat: support PostgreSQL PREPARE parameter types - #2657
Merged
manticore-projects merged 1 commit intoSep 21, 2026
Merged
manticore-projects merged 1 commit into
manticore-projects merged 1 commit into
Conversation
Signed-off-by: minleejae <mmj9808@gmail.com>
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PREPARE p(bigint) AS SELECT ...currently fails because PrepareStatement only supports inferred parameter types. Add an optional structured parameter-type list, reusing ColDataType for arrays, qualified names, and type modifiers, with PostgreSQL UNKNOWN retained for inference.Add a statement-writer overload to the existing renderer so StatementDeParser delegates the prepared query/DML to the configured visitors. This fixes nested expressions bypassing a custom ExpressionDeParser. Existing constructors and the untyped form remain available. Tests cover type edits, quoted names, SELECT/INSERT/UPDATE/DELETE, JDBC parameter preservation, and malformed lists.
Syntax reference: PostgreSQL PREPARE.
Validation:
check: 7,823 XML-reported tests, 0 failures/errors, 25 skipped; formatting, grammar ambiguity, Checkstyle, PMD, and JMH compilation passed. Formatting was checked against upstream/master using a local Spotless ratchet override.