fix: avoid recursion when deparsing statement lists - #2651
Merged
manticore-projects merged 1 commit intoSep 20, 2026
Merged
manticore-projects merged 1 commit into
manticore-projects merged 1 commit into
Conversation
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
Statements.accept(new StatementDeParser(builder), context)currently throwsStackOverflowError, even for an empty list: the deparser visits the same container again instead of its children. This prevents callers from rendering or rewriting a parsed SQL script through one visitor.This change visits each child statement and shares list separators between
Statements.toString()andStatementDeParser.BlockandIfElseStatementgain callback-based rendering overloads, so nested lists use the same separator policy and IF conditions and branches reach custom visitors. The supplied context is forwarded at those dispatch points. ExistingtoString()output, branch/block semicolon flags, and error-recovery null placeholders are preserved.Regression coverage includes empty and repeated calls, adjacent DDL/DML statements, nested blocks, IF/ELSE delimiter flags, custom condition and statement visitors, AST immutability, unsupported statements and error recovery. Dialect round trips cover MySQL, PostgreSQL quoted routine/DO bodies, Oracle blocks and SQL Server IF statements. The usage guide includes a complete-list deparser example.
Validation:
./gradlew spotlessApply check --no-daemon: 7,505 tests, 0 failures/errors, 25 skipped; includes 30 new regression cases.mvn --batch-mode --no-transfer-progress clean verify: 7,487 tests, 0 failures/errors, 25 skipped.The change is confined to rendering and visitor dispatch; it does not change the grammar or interpret procedural bodies.