Run examples in conda-recipe-cf workflow and run examples on Windows - #2383
Merged
Merged
Conversation
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Collaborator
|
coverage: 74.959%. remained the same — add-windows-examples-workflow into master |
ndgrigorian
force-pushed
the
add-windows-examples-workflow
branch
from
September 17, 2026 23:58
1080ad2 to
11a4b49
Compare
ndgrigorian
marked this pull request as ready for review
September 18, 2026 00:50
ndgrigorian
requested review from
antonwolfy and
vlad-perevezentsev
as code owners
September 18, 2026 00:50
antonwolfy
previously approved these changes
Oct 1, 2026
antonwolfy
left a comment
antonwolfy
left a comment
Collaborator
There was a problem hiding this comment.
A couple of minor nits, but overall LGTM
ndgrigorian
force-pushed
the
add-windows-examples-workflow
branch
from
October 1, 2026 20:15
11a4b49 to
7206b75
Compare
antonwolfy
approved these changes
Oct 2, 2026
antonwolfy
left a comment
antonwolfy
left a comment
Collaborator
There was a problem hiding this comment.
No more comments from me
Thank you @ndgrigorian
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR runs dpctl examples in the
conda-recipe-cfworkflow, and also adds runs for examples on Windows to bothconda-recipe-cfandconda-recipeworkflowsAdditionally adjusts the C extension example to permit Windows builds