Fix bugs in kernel submission and creation - #2382
Merged
Merged
Conversation
ndgrigorian
requested review from
antonwolfy and
vlad-perevezentsev
as code owners
September 16, 2026 17:02
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Collaborator
|
coverage: 74.989% (+0.03%) from 74.959% — bug-fixes-for-kernel-submission into master |
antonwolfy
reviewed
Sep 30, 2026
Getting a named kernel from a kernel bundle that does not contain it could cause a crash. It was also possible for a kernel bundle wrapping a NULL reference, which could then be submitted and crash
ndgrigorian
force-pushed
the
bug-fixes-for-kernel-submission
branch
from
October 1, 2026 05:13
c1153db to
8eb2ec2
Compare
antonwolfy
previously approved these changes
Oct 1, 2026
antonwolfy
left a comment
antonwolfy
left a comment
Collaborator
There was a problem hiding this comment.
Thank you @ndgrigorian, LGTM with only small optional nit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses two bugs with dpctl's kernel bundle interoperability.
In the first bug, when creating a kernel bundle, it was possible for the resulting object to wrap a NULL reference if the creation somehow failed or could not link to a module. This would cause a crash at submission. It was also possible to get a NULL-wrapping kernel if providing a mangled name that doesn't exist.
The second bug, when submitting to a queue, if the number of arguments was incorrect, the user would not receive any feedback and it would act as if the submission succeeded.