ENH: Request ITK modules as COMPONENTS in Video/Remote/Nonunit examples - #487
Closed
hjmjohnson wants to merge 3 commits into
Closed
hjmjohnson wants to merge 3 commits into
hjmjohnson wants to merge 3 commits into
Conversation
Name the ITK modules behind each example's includes and link targets as find_package COMPONENTS, so configure fails with "No such module" when a module is missing rather than with a missing target at generate time. Link lines are unchanged: each example keeps its explicit ITK::<Name>Module targets, which show a reader which module provides which class. Follows the COMPONENTS approach proposed in InsightSoftwareConsortium#470. Co-Authored-By: Bradley Lowekamp <blowekamp@mail.nih.gov>
Name the ITK modules behind each example's includes and link targets as find_package COMPONENTS, so configure fails with "No such module" when a module is missing rather than with a missing target at generate time. Link lines are unchanged: each example keeps its explicit ITK::<Name>Module targets, which show a reader which module provides which class. Follows the COMPONENTS approach proposed in InsightSoftwareConsortium#470. Co-Authored-By: Bradley Lowekamp <blowekamp@mail.nih.gov>
Name the ITK modules behind each example's includes and link targets as find_package COMPONENTS, so configure fails with "No such module" when a module is missing rather than with a missing target at generate time. Link lines are unchanged: each example keeps its explicit ITK::<Name>Module targets, which show a reader which module provides which class. Follows the COMPONENTS approach proposed in InsightSoftwareConsortium#470. Co-Authored-By: Bradley Lowekamp <blowekamp@mail.nih.gov>
github-actions
Bot
added
type:Enhancement
Member
|
What is the point of separating these out? |
Member
Author
|
I was trying to make more bite sized units to review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Peeled from #481: the Video, Remote, and Nonunit examples request the ITK modules they use as
find_packageCOMPONENTS. Link lines keep their explicitITK::<Name>Moduletargets.What changed
CMakeLists.txtfiles, +74 −8.ITKImageIOstays the IO component; no per-format narrowing.${ITK_INTERFACE_LIBRARIES}.mainrather than rebased from WIP: Require ITK 6 and request modules as find_package COMPONENTS #481.Local verification
Built against ITK
main(6.0.0.20260907), macOS arm64:WikiExamplesmodule offThe two Remote examples request
ITKVtkGlue; both linkITK::ITKVtkGlueModuleunconditionally and sit insideif(ENABLE_QUICKVIEW).pre-commit run --all-filespasses.🤖 Generated with Claude Code
https://claude.ai/code/session_01S5zzoU6yyUwdLEvjM2s6iS