Conversation
…n genai/live Bumps `setuptools` (to 84.0.0) alongside several other dependencies (`scipy`, `numpy`, `soundfile`, `librosa`, `pytest`, `pytest-asyncio`) to resolve Dependabot security alerts. Additionally, this change: - Adjusts Python version testing in `noxfile_config.py`. - Comments out `pyaudio` (fails to build on Python >= 3.10) and removes `simpleaudio`. Note: 10 out of the 15 samples in this directory were already broken. To maintain the scope of this Dependabot dependency update, the necessary refactoring to fix these samples has been deferred to a separate task (b/563530665).
product-auto-label
Bot
added
the
samples
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates Python testing configurations and dependency versions, including upgrades to pytest, numpy, scipy, soundfile, and librosa. Feedback on these changes recommends adjusting the ignored Python versions in noxfile_config.py to ensure only the oldest (3.10) and newest (3.13) supported versions are tested, and removing the commented-out pyaudio dependency reference in requirements.txt as Python versions below 3.10 are no longer supported.
| TEST_CONFIG_OVERRIDE = { | ||
| # You can opt out from the test for specific Python versions. | ||
| "ignored_versions": ["3.8", "3.9", "3.11", "3.12", "3.13"], | ||
| "ignored_versions": ["3.8", "3.9", "3.10", "3.11", "3.13"], |
There was a problem hiding this comment.
According to the repository's testing guidelines, we should only test the oldest and newest supported Python releases in test configurations (such as noxfile_config.py), ignoring intermediate versions. Since Python 3.10 is the oldest supported version and Python 3.13 is the newest, we should test both 3.10 and 3.13, while ignoring 3.11 and 3.12.
| "ignored_versions": ["3.8", "3.9", "3.10", "3.11", "3.13"], | |
| "ignored_versions": ["3.8", "3.9", "3.11", "3.12"], |
References
- Only test the oldest and newest supported Python releases in test configurations (such as noxfile_config.py), ignoring intermediate versions.
| librosa==0.11.0 | ||
| simpleaudio==1.0.0 No newline at end of file | ||
| setuptools==84.0.0 | ||
| # pyaudio==0.2.14 pyudio cannot be built on python versions >=3.10 |
There was a problem hiding this comment.
Python versions below 3.10 are no longer supported. According to our guidelines, we should not specify fallback dependency versions or environment markers for Python versions older than 3.10. Please remove this line.
References
- Do not specify fallback dependency versions or environment markers for Python versions older than 3.10, as Python versions below 3.10 are no longer supported.
1 participant
Description
Bumps
setuptools(to 84.0.0) alongside several other dependencies (scipy,numpy,soundfile,librosa,pytest,pytest-asyncio) to resolve Dependabot securityalerts.
Additionally, this change:
noxfile_config.py.pyaudio(fails to build on Python >= 3.10) and removessimpleaudio.Note: 10 out of the 15 samples in this directory were already broken. To maintain the scope of this Dependabot dependency update, the necessary refactoring to fix these samples
has been deferred to a separate task (b/563530665).
Fixes b/559810242
Checklist
Testing
Compliance & Style
Post-Approval Actions