Conversation
# Conflicts: # src/gen/model-decoders/decoders.ts # src/gen/models/index.ts
Brings in main up to 0.8.10 (flat sendRequest response, new API spec fields, include_soft_deleted_comments). generate-openapi.sh takes main's tools/openapi generator path and keeps --opt response_dates_as_number=true. src/gen is main's generated code with only the date option applied on top: a three-way merge of main's src/gen against the generator's output with and without response_dates_as_number (both from the same chat spec), so nothing main ships is dropped. Mapping TimestampNS back to Date makes it identical to main's; decoders.ts, the models header and timestamp-guard.ts are unchanged from this branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking changes
In response models date fields were returned as
Dateobjects, these are now nanosecond timestamps. Helper methods are exported from the SDK to help with conversion (same helpers as exported fromstream-chat-js).Type checking for test files have been turned on.