Skip to content

fix(geode_id): Add geode_id param and enforce id lenghts + add tests #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BotellaA merged 3 commits into from
Oct 2, 2026
Merged

fix(geode_id): Add geode_id param and enforce id lenghts + add tests #277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
79265ea
fix(geode_id): Add geode_id param and enforce id lenghts + add tests
MaxNumerique Oct 2, 2026
f738c35
Apply prepare changes
MaxNumerique Oct 2, 2026
e753fec
subclasses type
MaxNumerique Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
174 changes: 131 additions & 43 deletions opengeodeweb_back_schemas.json
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 4 additions & 0 deletions opengeodeweb_back_typed_schemas.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ export interface PolygonalSurfacePoint {
export interface CreatePolygonalSurfaceResponse {
binary_light_viewable?: string;
collection_components?: CreatePolygonalSurfaceResponseCollectionComponent[];
geode_id: string;
geode_object_type: string;
id: string;
is_viewable: boolean;
Expand Down Expand Up @@ -59,6 +60,7 @@ export interface Point {
export interface CreatePointSetResponse {
binary_light_viewable?: string;
collection_components?: CreatePointSetResponseCollectionComponent[];
geode_id: string;
geode_object_type: string;
id: string;
is_viewable: boolean;
Expand Down Expand Up @@ -103,6 +105,7 @@ export interface EdgedCurvePoint {
export interface CreateEdgedCurveResponse {
binary_light_viewable?: string;
collection_components?: CreateEdgedCurveResponseCollectionComponent[];
geode_id: string;
geode_object_type: string;
id: string;
is_viewable: boolean;
Expand Down Expand Up @@ -185,6 +188,7 @@ export interface SaveViewableFileParams {
export interface SaveViewableFileResponse {
binary_light_viewable?: string;
collection_components?: SaveViewableFileResponseCollectionComponent[];
geode_id: string;
geode_object_type: string;
id: string;
is_viewable: boolean;
Expand Down
1 change: 0 additions & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,4 +66,3 @@ werkzeug==3.1.8
# flask
# flask-cors

opengeodeweb-microservice==1.*,>=1.3.0rc1
3 changes: 2 additions & 1 deletion src/opengeodeweb_back/routes/blueprint_routes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,7 +649,8 @@ def get_all_bases(geode_class: type) -> set[type]:
return bases

def get_all_subclasses(geode_class: type) -> set[type]:
subclasses = set()
subclasses: set[type] = set()
subclass_class: type
for subclass_class in geode_class.__subclasses__():
subclasses.add(subclass_class)
subclasses.update(get_all_subclasses(subclass_class))
Expand Down
32 changes: 25 additions & 7 deletions src/opengeodeweb_back/routes/create/schemas/edged_curve.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,9 @@
"type": "string"
},
"id": {
"type": "string"
"type": "string",
"minLength": 32,
"maxLength": 32
},
"name": {
"type": "string"
Expand Down Expand Up @@ -92,7 +94,9 @@
"type": "integer"
},
"geode_id": {
"type": "string"
"type": "string",
"minLength": 36,
"maxLength": 36
},
"name": {
"type": "string"
Expand All @@ -103,13 +107,17 @@
"boundaries": {
"type": "array",
"items": {
"type": "string"
"type": "string",
"minLength": 36,
"maxLength": 36
}
},
"internals": {
"type": "array",
"items": {
"type": "string"
"type": "string",
"minLength": 36,
"maxLength": 36
}
},
"is_active": {
Expand All @@ -134,7 +142,9 @@
"type": "object",
"properties": {
"geode_id": {
"type": "string"
"type": "string",
"minLength": 36,
"maxLength": 36
},
"name": {
"type": "string"
Expand All @@ -145,7 +155,9 @@
"items": {
"type": "array",
"items": {
"type": "string"
"type": "string",
"minLength": 36,
"maxLength": 36
}
},
"is_active": {
Expand All @@ -161,6 +173,11 @@
],
"additionalProperties": false
}
},
"geode_id": {
"type": "string",
"minLength": 36,
"maxLength": 36
}
},
"required": [
Expand All @@ -169,7 +186,8 @@
"name",
"viewer_type",
"is_viewable",
"geode_object_type"
"geode_object_type",
"geode_id"
],
"additionalProperties": false
}
Expand Down
1 change: 1 addition & 0 deletions src/opengeodeweb_back/routes/create/schemas/edged_curve.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ class EdgedCurveResponse(DataClassJsonMixin):
def __post_init__(self) -> None:
print_dataclass(self)

geode_id: str
geode_object_type: str
id: str
is_viewable: bool
Expand Down
32 changes: 25 additions & 7 deletions src/opengeodeweb_back/routes/create/schemas/point_set.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,9 @@
"type": "string"
},
"id": {
"type": "string"
"type": "string",
"minLength": 32,
"maxLength": 32
},
"name": {
"type": "string"
Expand Down Expand Up @@ -78,7 +80,9 @@
"type": "integer"
},
"geode_id": {
"type": "string"
"type": "string",
"minLength": 36,
"maxLength": 36
},
"name": {
"type": "string"
Expand All @@ -89,13 +93,17 @@
"boundaries": {
"type": "array",
"items": {
"type": "string"
"type": "string",
"minLength": 36,
"maxLength": 36
}
},
"internals": {
"type": "array",
"items": {
"type": "string"
"type": "string",
"minLength": 36,
"maxLength": 36
}
},
"is_active": {
Expand All @@ -120,7 +128,9 @@
"type": "object",
"properties": {
"geode_id": {
"type": "string"
"type": "string",
"minLength": 36,
"maxLength": 36
},
"name": {
"type": "string"
Expand All @@ -131,7 +141,9 @@
"items": {
"type": "array",
"items": {
"type": "string"
"type": "string",
"minLength": 36,
"maxLength": 36
}
},
"is_active": {
Expand All @@ -147,6 +159,11 @@
],
"additionalProperties": false
}
},
"geode_id": {
"type": "string",
"minLength": 36,
"maxLength": 36
}
},
"required": [
Expand All @@ -155,7 +172,8 @@
"name",
"viewer_type",
"is_viewable",
"geode_object_type"
"geode_object_type",
"geode_id"
],
"additionalProperties": false
}
Expand Down
1 change: 1 addition & 0 deletions src/opengeodeweb_back/routes/create/schemas/point_set.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ class PointSetResponse(DataClassJsonMixin):
def __post_init__(self) -> None:
print_dataclass(self)

geode_id: str
geode_object_type: str
id: str
is_viewable: bool
Expand Down
32 changes: 25 additions & 7 deletions src/opengeodeweb_back/routes/create/schemas/polygonal_surface.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,9 @@
"type": "string"
},
"id": {
"type": "string"
"type": "string",
"minLength": 32,
"maxLength": 32
},
"name": {
"type": "string"
Expand Down Expand Up @@ -91,7 +93,9 @@
"type": "integer"
},
"geode_id": {
"type": "string"
"type": "string",
"minLength": 36,
"maxLength": 36
},
"name": {
"type": "string"
Expand All @@ -102,13 +106,17 @@
"boundaries": {
"type": "array",
"items": {
"type": "string"
"type": "string",
"minLength": 36,
"maxLength": 36
}
},
"internals": {
"type": "array",
"items": {
"type": "string"
"type": "string",
"minLength": 36,
"maxLength": 36
}
},
"is_active": {
Expand All @@ -133,7 +141,9 @@
"type": "object",
"properties": {
"geode_id": {
"type": "string"
"type": "string",
"minLength": 36,
"maxLength": 36
},
"name": {
"type": "string"
Expand All @@ -144,7 +154,9 @@
"items": {
"type": "array",
"items": {
"type": "string"
"type": "string",
"minLength": 36,
"maxLength": 36
}
},
"is_active": {
Expand All @@ -160,6 +172,11 @@
],
"additionalProperties": false
}
},
"geode_id": {
"type": "string",
"minLength": 36,
"maxLength": 36
}
},
"required": [
Expand All @@ -168,7 +185,8 @@
"name",
"viewer_type",
"is_viewable",
"geode_object_type"
"geode_object_type",
"geode_id"
],
"additionalProperties": false
}
Expand Down
1 change: 1 addition & 0 deletions src/opengeodeweb_back/routes/create/schemas/polygonal_surface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ class PolygonalSurfaceResponse(DataClassJsonMixin):
def __post_init__(self) -> None:
print_dataclass(self)

geode_id: str
geode_object_type: str
id: str
is_viewable: bool
Expand Down
3 changes: 2 additions & 1 deletion src/opengeodeweb_back/routes/schemas/cell_attribute_names.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
"properties": {
"id": {
"type": "string",
"minLength": 1
"minLength": 32,
"maxLength": 32
}
},
"required": [
Expand Down
3 changes: 2 additions & 1 deletion src/opengeodeweb_back/routes/schemas/edge_attribute_names.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
"properties": {
"id": {
"type": "string",
"minLength": 1
"minLength": 32,
"maxLength": 32
}
},
"required": [
Expand Down
6 changes: 4 additions & 2 deletions src/opengeodeweb_back/routes/schemas/model_component_edge_attribute_names.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,15 @@
"properties": {
"id": {
"type": "string",
"minLength": 1
"minLength": 32,
"maxLength": 32
},
"component_ids": {
"type": "array",
"items": {
"type": "string",
"minLength": 1
"minLength": 36,
"maxLength": 36
},
"minItems": 1
}
Expand Down
6 changes: 4 additions & 2 deletions src/opengeodeweb_back/routes/schemas/model_component_polygon_attribute_names.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,15 @@
"properties": {
"id": {
"type": "string",
"minLength": 1
"minLength": 32,
"maxLength": 32
},
"component_ids": {
"type": "array",
"items": {
"type": "string",
"minLength": 1
"minLength": 36,
"maxLength": 36
},
"minItems": 1
}
Expand Down
Loading
Loading