Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fixes for players dropping mid-match and hosts getting booted from their own lobby, split out from #625 so they can ship first.
Joiners never had working TURN credentials because their network mesh was created before the join response that carries them, so they had no relay to fall back on when a direct route died. During a match, a broken link could also end up with nobody asking to re-signal it, since only the later joiner retried and it stopped after two attempts; retries are no longer capped during an online match. A failed lobby lookup mid-match no longer tears down the match's connections, and a failed service config refresh no longer switches off signalling retries.
For the lobby host: a leftover anticheat "leave lobby" request is now cleared when its session ends, so it can't eject the host from the next lobby they create, and the host no longer leaves its own lobby because it can't reach one peer.