fix(userdata): Support non-ASCII Documents paths and survive unreadable user files - #622
Merged
x64-dev merged 8 commits intoSep 29, 2026
Conversation
…ge and Unicode window
…rite them atomically
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Players with Cyrillic or Arabic characters in their Documents path couldn't use their user data folder, and since the sentry update the game crashed on launch for them. The exe now runs with the UTF-8 code page, so file paths work no matter what characters they contain. On Windows before 10 1903, where that setting is ignored, it falls back to the short 8.3 path.
The game window is now Unicode too, which also fixes typing Cyrillic or Arabic in chat. Lobby map names are sent as UTF-8, so non-ASCII map names no longer break, and name conversions in the UI no longer garble non-ASCII text.
It also stops the game from crashing or losing settings when a file can't be read, for example a OneDrive file that isn't downloaded. A broken MapCache.ini gets rebuilt, a broken save shows an error, and Options.ini and the online settings are never overwritten after a failed load and are written safely. There are a few smaller fixes too: BIG file header checks, a buffer overflow on long paths, and the lobby camera height default and range check.