fix: preserve browser scroll position and configure commit attribution - #3261
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Browser clicks, input focus, screenshots, and pointer actions now reveal targets with minimal scrolling and use their visible center. Wheel actions respect overflow rules, avoiding displacement of hidden shell containers. A packaged desktop regression runner covers these interactions.
Built-in commit workflows now resolve the execution host's co-author preference when loaded. Quick Actions settings expose an opt-out, preserve legacy defaults and unrelated settings, and disable the control for older hosts that omit the field.
Type and Areas
Bug fix / feature. WebDriver adapter, browser tools, configuration contracts, built-in skill loading, Web UI settings, locales, and E2E helpers.
Motivation / Impact
Already-visible browser targets should keep their position when activated. Users can also choose whether new commits from the built-in workflow credit OpenBitFun as a co-author; the PR footer contract remains intact.
Verification
AI-assisted; focused automated validation completed:
pnpm.cmd run fmt:rspnpm.cmd run check:webpnpm.cmd run i18n:auditpnpm.cmd run check:core-boundariesnode --test --test-name-pattern='third-party capability profiles' scripts/check-core-boundaries.test.mjs(1 passed)cargo check --locked -p openbitfun-webdrivercargo test --locked -p openbitfun-config-contracts --lib(94 passed)pnpm.cmd --dir src/web-ui run test:run src/infrastructure/config/services/AIExperienceConfigService.test.ts(10 passed)cargo test --locked -p openbitfun-core --no-default-features --features agent-runtime,tools-browser-web,tools-computer-use,git --lib runtime_settings::(3 passed)browser_control::actions::(23 passed, 1 existing real-browser test ignored)node --check tests/e2e/scripts/run-interaction-scroll.mjsgit diff --check,git merge-tree --write-tree origin/main HEAD, and Git object size check passed.The wider
agentic::tools::implementations::skills::filter produced 51 passes and one existing Windows failure:claude_scan_distinguishes_unsupported_fields_from_invalid_markdownuses a slash-specific string suffix assertion for a native path. This assertion and scanner behavior are unchanged by the PR.Reviewer Notes
Prepared directly on
gcwing/dev. Local audit/design/process documentation is excluded; the changed built-incommit-push-pr/SKILL.mdis executable product content required by the new runtime setting.Native/browser visual verification and the packaged E2E runner were not executed. Remote workspace, mobile/IM remote control, Peer Device Mode, and Detached Dispatch were not exercised end to end; no remote execution claim is made from the local tests.
Checklist