Conversation
… src/ hyperlink 0.3.2 exits non-zero when --sources points at a directory that is not there, which ends the step before it prints the broken links it found. The website is removing src/ as the last of its pages move to Nuxt, so name the tree at run time: src/ while it exists, nuxt/content once it does not.
Contributor
Author
|
this is in draft state until the required PRs have merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Check linksstep passes--sources website/src. hyperlink 0.3.2 exits non-zero when that path is not there, and it does so after finding broken links but before printing them, so the report reads as a missing directory instead.FlowFuse/website is retiring Eleventy and deleting
src/in FlowFuse/website#5795, which is what makes the hardcoded path fail. This resolves the tree at run time instead:website/srcwhile it exists,website/nuxt/contentonce it does not.Backward compatible, so
mainkeeps pointing atsrc/until that PR lands.Draft until the website PRs under FlowFuse/website#5777 have merged, since merging here releases
build_website/v1straight away.