Repository navigation
Conversation
mathieucarbou
previously approved these changes
Oct 6, 2026
willmmiles
requested changes
Oct 6, 2026
Enable WebRequestMethodComposite(http_method::HTTP_QUERY) only when the platform parser advertises QUERY support, so platforms without the enum stay buildable.
EyJunge1
force-pushed
the
followup/http-query-idf-mapping
branch
from
October 7, 2026 05:25
759c45f to
d4e210d
Compare
EyJunge1
changed the title
willmmiles
reviewed
Oct 7, 2026
| : MAP_EXTERNAL_TERNARY(HTTP_PURGE) | ||
| : MAP_EXTERNAL_TERNARY(HTTP_LINK) | ||
| : MAP_EXTERNAL_TERNARY(HTTP_UNLINK) | ||
| #if defined(HTTP_PARSER_HAS_QUERY) |
There was a problem hiding this comment.
Does any platform set this? As far as I can tell, the upstream ESP-IDF PR does not expose this macro.
Author
|
You're right nothing currently defines |
mathieucarbou
added
Status: Pending Merge
Type: Improvement
and removed
Status: Pending Merge
labels
mathieucarbou
dismissed
their stale review
October 7, 2026 10:35
Waiting for: espressif/esp-idf#19194
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
http_method::HTTP_QUERYviaMAP_EXTERNAL_TERNARY(HTTP_QUERY)behind#if defined(HTTP_PARSER_HAS_QUERY), so only platforms that advertise QUERY support get the bridge.HTTP_QUERYparsing was already added in Add HTTP QUERY method (RFC 10008) #474; this is only the platform enum bridge.Closes #476
Related: #474, #475, espressif/esp-idf#19071
Test plan
HTTP_PARSER_HAS_QUERYandASYNCWEBSERVER_HTTP_METHOD_INTEGRATIONenabled → mapping worksHTTP_PARSER_HAS_QUERY→ still compiles