Set SOURCE_DATE_EPOCH when building uv to prevent A64FX segfault - #308
Merged
Merged
Conversation
Add a pre-prepare hook to set SOURCE_DATE_EPOCH for uv builds to ensure a timestamp is available in A64FX builds
Neves-P
changed the title
SOURCE_DATE_EPOCH when building uv to prevent A64FX segfault
Neves-P
added
2025.06-software.eessi.io
bedroge
reviewed
Sep 25, 2026
Co-authored-by: Bob Dröge <b.e.droge@rug.nl>
Add pre-prepare hook to set SOURCE_DATE_EPOCH for uv builds.
Update pre_prepare_hook_uv_source_date_epoch to derive SOURCE_DATE_EPOCH from the source archive's timestamp, ensuring deterministic builds for uv.
Member
Author
|
The revised approached works: EESSI/software-layer#1668 (comment), so this is ready for review. |
Neves-P
marked this pull request as ready for review
September 28, 2026 15:13
Member
Author
|
I added a guard to only apply the changes in the hook for A64FX builds. It also seems to work: EESSI/software-layer#1668 (comment) |
bedroge
reviewed
Sep 29, 2026
| ) | ||
|
|
||
| cpu_target = get_eessi_envvar('EESSI_SOFTWARE_SUBDIR') | ||
| if cpu_target == CPU_TARGET_A64FX: |
Contributor
There was a problem hiding this comment.
I'd add another guard here that only applies this to a specific version of uv. Hopefully it won't be necessary for future versions, but otherwise we can still extend that list.
bedroge
approved these changes
Sep 30, 2026
Contributor
|
bot: build repo:eessi.io-2023.06-software instance:eessi-bot-deucalion for:arch=aarch64/a64fx |
|
New job on instance
|
|
New job on instance
|
|
New job on instance
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a pre-prepare hook to set
SOURCE_DATE_EPOCHforuvbuilds to ensure a timestamp is available in A64FX builds. Without this, this fails trying to buildmaturinwhen buildinguv. Note: this first tries if setting the variable works, otherwise we should try to use a proper source date timestamp and not generate it on build, hence I'm first making this a draft.