Includes a redirect to the 404 page when accessing community, collect…

[DanGastardelli]

References

#6260

Description

When accessing a community, collection, or item page without an ID, a blank page appears with no message or error.

The user should see a 404 error page instead.

Instructions for Reviewers

Access pages such as:

http://localhost:4000/communities

http://localhost:4000/collections

http://localhost:4000/items

The 404 error page should be displayed.

In the "community-page", "collection-page", and "item-page" components, I added the following handling in the routing configuration:

{
path: '',
component: ThemedPageNotFoundComponent,
canActivate: [endUserAgreementCurrentUserGuard],
}

[FrancescoMolinaro]

Hi @DanGastardelli , many thanks for your work on this, much appreciated.

Overall the approach looks good to me, I would just consider to applying the same fix also on other routes, for instance:

/edit-items or /bitstreams

In general all the routes that ends with a param like :id/:something can produce this issue.
I would also remove the guard endUserAgreementCurrentUserGuard as in general we don't guard the 404, check app-routes.ts for reference.

For consistency with the app-level 404 page and to avoid issue with the missing title I would suggest to use the same configuration we have in the main routing file, something like:

{ path: '', component: ThemedPageNotFoundComponent, pathMatch: 'full', data: { title: '404.page-not-found' } }

[DanGastardelli]

Hi @FrancescoMolinaro

I’ve made the requested adjustments, expanding on the proposed approach.