Repository navigation
Fix: 5503, applying fixes for mobile/tablet screens - #6091
Open
abelc-escire wants to merge 3 commits into
Open
abelc-escire wants to merge 3 commits into
abelc-escire wants to merge 3 commits into
Conversation
nathanmlf
approved these changes
Aug 17, 2026
nathanmlf
left a comment
There was a problem hiding this comment.
Hi @abelc-escire! I've tested it on my end and everything is working as expected. Nice job with the improvements! I will leave some screenshots below showing how it looks.
lgeggleston
requested changes
Oct 5, 2026
lgeggleston
left a comment
Contributor
There was a problem hiding this comment.
Hi @abelc-escire, Nice work with this overall these are good improvements to have!
After testing the 3 main updates:
- The footer links look good and distribute well over mobile viewports; tested with even and odd # of links
- The whitespace removal on Search Tools looks good
- However, I have some concerns about the navigation search bar. It's no longer partially hidden, but there's now a content shift of the rest of the page that occurs whenever it's opened and there's a delay on close, both of which are an issue for page performance. Would it be possible to keep the style changes as minimal as possible by still overlaying and avoiding a layout shift, but opening the bar underneath instead of to the left as you have here?
Author
|
Hi @lgeggleston, I applied some fixes based on the requested changes. Could you please take a look to make sure everything is working as expected? Regards! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References issue
Fixes #5503
Description
Applying fixes for mobile/table screens to fit properly on those screen sizes.
Instructions for Reviewers
To test those scenarios please move to mobile/tablet screens and then follow the following instructions.
List of changes in this PR:
Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.