fix(security): 拆除 API Key create/revoke 确认层,恢复 LocalAdmin - #7
Merged
Merged
Conversation
LocalAdmin create|revoke now runs immediately. Remote /control/console/command (HTTP + WS) still hard-rejects sldataapi/slda via RemoteCommandGuard. Co-authored-by: DNT_OF <allowcache@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owner 实机测试确认:
sldataapi apikey create|revoke的 y/N / 全屏 / 新 cmd 确认 UX 破坏了 LocalAdmin。端点层防御已经足够,整层拆除确认。本 PR 基于当前
preview/v2.6.0-DevOnlytip(acbed13)重做,不是合并 #6。#6 对着错误基线cursor/confirm-new-cmd-window-3ee0(新 cmd 窗口通道);当前 tip 上残留的是整屏接管实现(ConfirmPanel/ConfirmSession/ConsoleTakeover/OperatorConfirmService)。保留
Auth/RemoteCommandGuard:远程/control/console/command(HTTP + WScall同源ControlController.Handle)硬拒绝sldataapi/sldaapikey.config/sldataapi apikey命令面本身删除
OperatorConfirmService.Confirm调用(命令立即执行)OperatorConfirmService、ConfirmPanel、ConfirmSession、ConsoleTakeoverapi_key_confirm_timeout_seconds/ApiKeyConfirmTimeoutSecondsRemoteCommandGuard.IsAffirmative(仅给 y/N 行模式用)当前 tip 上本来就没有
confirmtest/ConfirmWindowChannel/ConfirmWindowProtocol,无需再删。本地控制台
create|revoke立即执行;远程仍然 403。未包含 WebDAV 或更新检查间隔改动。