Include the HEALPix pixel window in map-based pseudo-Cℓ bandpower windows - #366
Open
cailmdaley wants to merge 1 commit into
Open
cailmdaley wants to merge 1 commit into
cailmdaley wants to merge 1 commit into
Conversation
bandpower_window_from_workspace(wsp, nside=) multiplies NaMaster's decoupling window by pw²(ℓ) for a spectrum of HEALPix maps at nside, so the SACC window maps a theory C_ℓ to the measured bandpower. The map-based cosmo_val path passes its nside through pseudo_cl_to_sacc_part and pseudo_cl_to_sacc; the catalogue-based path has no pixel window and passes none. With the blinding PR (#253) the Cℓ_EE shift is computed through the SACC window as written. On its own that is consistent (data and shift share the window); once both land, this fix corrects the data and the shift together. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a spectrum measured on HEALPix maps, the bandpowers NaMaster returns are W·(pw²·C_ℓ): pixelisation smooths the field by the pixel window pw(ℓ), and the mode-coupling inversion does not undo it. The pseudo-Cℓ SACC stored W alone, so anything that predicts the data through the SACC window (a SACC likelihood, the Smokescreen Cℓ_EE shift in #253) compared the measurement to W·C_ℓ. This PR puts pw²(ℓ) into the stored window for map-based spectra.
What changes
bandpower_window_from_workspace(wsp, nside=None)multipliesWbyhp.pixwin(nside)**2whennsideis given.pseudo_cl_to_saccandPseudoClMixin.pseudo_cl_to_sacc_partforwardnside;calculate_pseudo_cl_mappasses its mapnside. The catalogue-based path passes none: it has no pixels, so its window is unchanged.Effect on results
generate_pseudo_cl.py,generate_pseudo_cl_cov.pyandpapers/cosmo_valall usecell_method="catalog".cell_method="map", theCosmologyValidationdefault): at the configured nside = 1024, ℓ_max = 2·nside = 2048, pw² suppresses the prediction by 0.09% at ℓ = 100, 2.2% at 500, 8.5% at 1000 and 32% at 2047. The top powspace bands are the ones a fit through the old window got wrong.calculate_pseudo_cl_eb_covalready multiplies by pw², so the covariance and the window now agree.Interaction with #253
The blinding shift is ΔCℓ_EE passed through the SACC window (PRD #241 §4). Once both land, the shift and the data it conceals use the same window, pw² included, for map-based spectra.
Verified
test_pseudo_cl_to_sacc_real_namasterchecks the map-based window equals pw²(ℓ)·W against a real NaMaster workspace (rtol 1e-12). Container suite: 306 passed, 1 xfailed.— Claude (Opus) on behalf of Cail.
🤖 Generated with Claude Code