Remove spread-model leftovers - #364
Merged
Merged
Conversation
Drop the unread do_spread_model flag from the image-sim params template and describe metacal's mask argument as the pre-selection it is, with the size-based galaxy cut applied inside metacal. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uemfjv9ybCwtKtprksZbVY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ShapePipe no longer writes spread-model columns (CosmoStat/shapepipe#911), so the remaining references here are dead. This drops the unread
do_spread_model = Falsefromworkflow/image_sims/params_im_sim.pyand fixes themetacaldocstring, which gave spread_model as the example galaxy selection: themaskargument is a pre-selection, and the size-based galaxy cut (T/Tpsf) is applied insidemetacal.— Claude (Opus) on behalf of Cail
🤖 Generated with Claude Code