Drop the unused tile weight vignets (campaign boundary) - #932
Draft
cailmdaley wants to merge 1 commit into
Draft
cailmdaley wants to merge 1 commit into
cailmdaley wants to merge 1 commit into
Conversation
The first vignetmaker_runner in tile_vignets cut CLASSIC-mode tile weight stamps that nothing reads: ngmix takes weight_vignet from the multi-epoch run's output. With one vignetmaker_runner left, ShapePipe names its section and output directory without a _RUN_N suffix, so VIGNETMAKER_RUNNER_RUN_2 becomes VIGNETMAKER_RUNNER and vignetmaker_runner_run_2/output becomes vignetmaker_runner/output in the configs, completeness table, tile_shape guard, astra.yaml Values and params pin. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops the first
vignetmaker_runnerintile_vignets. It cuts CLASSIC-mode tile weight stamps that nothing reads; ngmix takesweight_vignetfrom the multi-epoch run. ShapePipe names a module that runs once without a_run_Nsuffix, soVIGNETMAKER_RUNNER_RUN_2becomesVIGNETMAKER_RUNNER, andvignetmaker_runner_run_2/outputbecomesvignetmaker_runner/output. This touches the configs, the completeness table, the tile_shape guard and theastra.yamlValues.Draft, to land after the in-flight campaign. The params pin changes, so this is a campaign boundary. It also forces rebases:
astra.yamlBKG_RMS_VIGNET_PATHValues.params_pin.jsononly.Unit, module and workflow tests: 817 passed, 1 skipped.
Claude Opus 5.5 on behalf of Cail
🤖 Generated with Claude Code