Retire in-code catalogue versioning and the pre-Snakemake run layers - #880
Draft
cailmdaley wants to merge 4 commits into
Draft
cailmdaley wants to merge 4 commits into
cailmdaley wants to merge 4 commits into
Conversation
cailmdaley
force-pushed
the
feat/persist-exp-products
branch
from
September 9, 2026 13:00
0d7c313 to
d91da36
Compare
cailmdaley
force-pushed
the
feat/retire-versioning
branch
from
September 10, 2026 00:46
77af691 to
8ac4caa
Compare
Contributor
Author
|
From the smk-g7 acceptance run (integration of #879 + #886 + #887 + this branch, 64 tiles / 127 exposures): — Claude (Fable) on behalf of Cail |
cailmdaley
force-pushed
the
feat/retire-versioning
branch
from
September 26, 2026 09:26
96d54ab to
54e4166
Compare
cailmdaley
changed the base branch from
feat/persist-exp-products
to
develop
September 28, 2026 16:33
ccd_psf_handler (v1.3/v1.4 -> 7, v1.5 -> 8, v1.6 -> 9 patches), its get_ccds_with_psf entry points and the build_and_plot_coverage_maps.sh VERSIONS loop go, with utilities/summary.py, summary_params_pre_v2.py, summary_run and summary_tiles.py: a per-patch scrape of a finished run whose job is done by the workflow's manifests, logs and completeness.py. collate_star_cat.py keeps only its version-free path (no -V/-P, no patch loop). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BeQNTBcjTqu6TPktxysovQ
The gen-0 HTCondor-era scripts and the gen-1 curl/skaha submission layer
(${kind}_runs/$ID layout, bit-coded job masks, patch-specific special
cases) go, with canfar_submit.py, canfar_submit_job and the skaha
dependency. canfar_monitor/canfar_monitor_log stay. The gen-2 bash
(run_job_sp_canfar_v2.0.bash, job_sp_canfar_v2.0.bash, functions.sh's
command()) stays: sp_validation's image-sims workflow calls it. The
Dockerfile's script-symlink loops tolerate an empty glob.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BeQNTBcjTqu6TPktxysovQ
merge_headers, psfex_interp and vignetmaker lose the single-run-root branch resolved through log_run_sp.txt (last:/all:): EXP_BASE_DIR and ME_*_EXP_DIR are required, and a config without them fails loudly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BeQNTBcjTqu6TPktxysovQ
docs/source/workflow.md is the user-facing workflow guide; pipeline_tutorial.md follows the rule chain; pipeline_canfar.md and post_processing.md go with the layers they described. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BeQNTBcjTqu6TPktxysovQ
cailmdaley
force-pushed
the
feat/retire-versioning
branch
from
September 29, 2026 08:09
496d67b to
b88c389
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retire in-code catalogue versioning and the pre-Snakemake run layers
Branch:
split/retire-versioning→develop. 4 commits, 58 files, +607 / −8112. Every deleted file is ondevelopat240b37e4.Why
ShapePipe writes shear catalogues; it never reads, reprocesses, or stays compatible with a v1.x run, so the code has no business knowing which catalogue version it produces — git tags are the version. It still carried the v1.x era: the
v1.3/v1.4 → 7,v1.5 → 8,v1.6 → 9patch tables,-V/-Pflags,P1..P9loops, the post-hocsummary/+missing_job_*scrape, and two generations of CANFAR bash whose job the Snakemake workflow does. After this PR no code path branches on a catalogue version.pipeline/andmodules/held no versioning — only three dual-layouthas_optionswitches (EXP_BASE_DIR,ME_DOT_PSF_EXP_DIR,ME_IMAGE_EXP_DIR) whose legacy branches were reachable fromexample/cfis/defunct/alone. The mass is run infrastructure.Retired
ccd_psf_handler.py,get_ccds_run.py,get_ccds_with_psf.py,build_and_plot_coverage_maps.sh— the version table and itsVERSIONSlooputilities/summary.py,summary_params_pre_v2.py,summary_run,summary_tiles.py,summary_run.ipynb,post_processing.md— per-patch scrape,n_patch = 8hardcodedmanifests/,logs/,completeness.py,sp reportcollate_star_cat.py:-V/-Ppatch loop, and the-p mccdbranch (focal-plane CCD ids, Jacobian rotation of external-mccd moments)psf_model: mccdcanfar_submit.py,canfar_submit_job,init_run_exclusive_canfar.sh,job_sp_canfar.bash,combine_runs.bash,distribute_tiles.py,link_to_exp_for_tile.py,merge_final_cat.py, … ;skahaprepare/exposure/tile.smk,canfar_monitormerge_headers/psfex_interp/vignetmakerrunners'log_run_sp.txtbranchEXP_BASE_DIR/ME_*_EXP_DIRfails loudlyThe header-download / corner-extraction coverage chain is not retired here: #887 replaces it with the exposure-count map and removes it there.
Deliberately kept
run_job_sp_canfar_v2.0.bash,job_sp_canfar_v2.0.bash,functions.sh→command()): sp_validation'simage_sims.smkcalls it. Version-free; retires with the image-sims port.create_final_cat.py: writes thepatches/<run>group sp_validation reads; renaming lands in lockstep there.completeness.py,ngmix_range.py,tile_local(): their content is part of ruleparams, so edits rerun finished units; comment edits wait for a campaign boundary.Questions
check_tile_coverage.pyclaims an sp_validation caller we can't find — live?merge_final_cat.pywas the only merger for per-tile randoms; needed for the tomographic round?collate_star_cat.py -p mccd?Merging with #887: trivial conflicts in
pyproject.toml[project.scripts](drop all four entry points),tests/module/test_coverage.py(take #887's) and theworkflow/README.mdscripts list (keep both).Tests:
tests/unit tests/workflow tests/module/{test_coverage,test_psfex_interp,test_vignetmaker,test_pipeline,test_run}.py— 489 passed, 1 skipped in the dev image.— Claude (Opus) on behalf of Cail