Skip to content

Pin PSFEx's compiled-in SAMPLE_* candidate cuts explicitly in default.psfex #919

Description

@cailmdaley

workflow/config/cfis/default.psfex sets SAMPLE_AUTOSELECT N and leaves every other SAMPLE_* key to PSFEx's compiled-in defaults — a second PSF-star selection no config records. From psfex -dd in the develop-runtime image (PSFEx 3.21.1): SAMPLE_MINSN 20, SAMPLE_MAXELLIP 0.3, SAMPLE_FWHMRANGE 2.0,10.0, SAMPLE_VARIABILITY 0.2, SAMPLE_FLAGMASK 0x00fe, SAMPLE_WFLAGMASK 0x0000, SAMPLE_IMAFLAGMASK 0x0, BADPIXEL_FILTER N. Which of these still act with autoselect off is not stated in the PSFEx docs (MAXELLIP alone is a real cut on the PSF-star sample). Write them into default.psfex explicitly so the decision record (#875, star_selection_psf.psfex_candidate_vetting) can assert them and a PSFEx upgrade cannot move them silently; the [HARDCODED] marker then goes.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions