Skip to content

fix: Filter out users based on nsaccountlock in FreeIPA - #622

Merged
aln730 merged 1 commit into
ComputerScienceHouse:developfrom
NickJ-7010:develop
Sep 28, 2026
Merged

aln730 merged 1 commit into
ComputerScienceHouse:developfrom
NickJ-7010:develop

Conversation

@NickJ-7010

Copy link
Copy Markdown
Contributor

What

what the PR changes

Adds a filter in the /attendance/cm_members endpoint to remove disabled accounts via the nsaccountlock=TRUE attribute.

Why

why these changes were made

To fix issue #609

Test Plan

how did you verify these changes did what you expected

Verified against real ldap data and viewed the changes take effect in the podman localhost build

Env Vars

did you add, remove, or rename any environment variables

No

Documentation

did you add or update any documentation. PRs should, at the minimum, update documentation when they make existing documentation out of date.

No

Checklist

  • Tested all changes locally

@datadog-computersciencehouse

Copy link
Copy Markdown

Pipelines

⚠️ Warnings

Your PR has warnings. Please review the issues below.

🚦 1 Pipeline job failed

Sonarqube | Sonarqube Analysis

View in Datadog · View in GitHub Actions

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: d5ed9f4 | Docs | View more details | Give us feedback!

@aln730 aln730 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aln730
aln730 merged commit 70a4cfa into ComputerScienceHouse:develop Sep 28, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants