Removed bool() so member.py only counts approved seminars/meetings - #621
Merged
BigSpaceships merged 3 commits intoSep 28, 2026
Merged
BigSpaceships merged 3 commits into
BigSpaceships merged 3 commits into
Conversation
|
BigSpaceships
merged commit Sep 28, 2026
1aaff3d
into
ComputerScienceHouse:develop
2 of 3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removed bool() from approved technical seminars and committee meetings in gatekeep_values()
Why
gatekeep_values() wasn't actually filtering out pending seminars/meetings, so a member's page could show an inaccurate gatekeep status (like showing them passing gatekeep when they really aren't)
Test Plan
I ran this with a local DB with approved and pending seminar/meetings for a test user and it returned the correct number of seminars
Env Vars
No
Documentation
No
Checklist