fix(core): prevent concurrent quarantine destination overwrites - #207
Merged
Muawiya-contact merged 9 commits intoOct 3, 2026
Merged
Conversation
Muawiya-contact
deleted the
codex/fix-quarantine-destination-collisions
branch
October 3, 2026 04:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two quarantine requests can flatten different source paths to the same name in the same second. Previously, destination selection and movement happened before the manifest lock; rename or the copy fallback could overwrite the first file.
Closes #195
Changes
The fallback reserves its destination atomically:
Validation
Limits
The mutex serializes one process, including time spent copying large files. Independent processes must not share a quarantine directory: destination creation refuses overwrites, but the manifest still lacks an OS-level lock. Link/unlink and copy/remove are not crash-atomic; journaling remains separate work under the recovery design. All Linux, Windows and macOS core/CLI and desktop CI jobs passed.
Nine focused commits; no dependency or manifest-format changes.