Skip to content

London | 26-ITP-Sept | Maharit Belai | Sprint 2 | Course work - #1549

Open
MaharitB wants to merge 51 commits into
CodeYourFuture:mainfrom
MaharitB:sprint-2
Open

London | 26-ITP-Sept | Maharit Belai | Sprint 2 | Course work#1549
MaharitB wants to merge 51 commits into
CodeYourFuture:mainfrom
MaharitB:sprint-2

Conversation

@MaharitB

@MaharitB MaharitB commented Sep 20, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF-1039

Changelist

I have created a new pull request based on the instruction left on the comment section

Questions

@MaharitB
untill i do this commit the work wont git base wont run
05c3d45
@MaharitB
add ${} in backticks to creat a template literal to get initials from…
a4bfc54 
… the strings
@MaharitB
add slice() that would rerturn the dir part of the path
686ac69
@MaharitB
declared dotIndex to save the the index of the dot.
f44d3e1
@MaharitB
declared a variable startDirIndex to save the start index of the stri…
f5f7707 
…ng User
@MaharitB
delet content of slice()and replaced it to StartDirIndex
e1dda9e
@MaharitB
delet 2 notes from the 3-paths.js
02ff8cf
@MaharitB
change colon to semicolon
6f81459
@MaharitB
remove +1 from slice() to make the output include dot(.)
26b0b8b
@MaharitB
delet all comment lines
3e10e6d
@MaharitB
remove the comment lines
9a94c44
@MaharitB
explain the expression in order of mathematical operation
0bd5e8c
@MaharitB
wrote console.log() to see what the code is doing
1a1c60a
@MaharitB
format document
4d06615
@MaharitB
add a single line comment for both lines
4aa68ab
@MaharitB
add a comment on why it produces error
2d26b97
@MaharitB
add more to the comment
532b0fa
@MaharitB
add comment an answer to a first given question
f91783b
@MaharitB
write a console .log() to run the code
118a824
@MaharitB
edit code by enclosing the number by double quote then it will be tre…
41c8775 
…ated as a string
@MaharitB
edit the comment and delet the comments that were previously there
726810c
@MaharitB
add a coment on the error
ceffa2d
@MaharitB
fix the error by putting , in the replaceall() and answer the questions
8b2dbc2
@MaharitB
delet the question in the comment and edit my answer
c52de96
@MaharitB
run the code and edit my answers
4072533
@MaharitB
describ line by line code
b20c858
@netlify

netlify Bot commented Sep 20, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 4e3b868
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6ab1b628e610390008a52a8b
😎 Deploy Preview https://deploy-preview-1549--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

Sign in to view
@MaharitB MaharitB added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 20, 2026
@github-actions

This comment has been minimized.

Sign in to view
@MaharitB MaharitB added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Sep 20, 2026
abdishakoor-dev
abdishakoor-dev reviewed Sep 21, 2026
View reviewed changes

@abdishakoor-dev abdishakoor-dev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. 1.js, 2.js and 4.js all run now, and the dir line in 3-paths.js is right.

A few things are still open:

  1. 1-key-exercises/4-random.js lines 6 and 11, see my reply on that thread.

  2. 2-mandatory-errors/4.js line 2, see my reply on that thread.

  3. 3-mandatory-interpret/2-time-format.js answer f), see my reply on that thread.

  4. Prettier still flags 2-mandatory-errors/0.js. Please format that file.

Add the Needs Review label again when you have pushed.

@abdishakoor-dev abdishakoor-dev added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 21, 2026
@MaharitB MaharitB added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 21, 2026
abdishakoor-dev
abdishakoor-dev reviewed Sep 22, 2026
View reviewed changes

@abdishakoor-dev abdishakoor-dev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the list is done, thanks. Prettier passes on every file now too.

One note on 1-key-exercises/4-random.js line 6, see my reply there.

Marking this Complete.

@abdishakoor-dev abdishakoor-dev added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abdishakoor-dev abdishakoor-dev abdishakoor-dev left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MaharitB @abdishakoor-dev