London | 26-ITP- Sept | Chandramani Gaire | Sprint 1 | Forms Controls by gaireprakash20-ops · Pull Request #1507 · CodeYourFuture/Module-JavaScript-Fundamentals

gaireprakash20-ops · 2026-09-12T15:08:46Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Task code

CYF-1004

Changelist

I changed the HTML and made it according to the task requirements, as per the CYF assignment.

corrected sizes

size

netlify · 2026-09-12T15:08:52Z

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	`91e0c1a`
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/6aaae9c9359f8500085a4db7
😎 Deploy Preview	https://deploy-preview-1507--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

abdishakoor-dev

Good structure, with a label on every field and a submit button. Things to sort before it can be marked Complete:

Name validation rejects valid names. On the deploy preview, type Al or Är as the name and submit. Both are refused, and the task says two non-space characters is enough. See line 20.
Reload the page and press Submit without touching either dropdown. It goes through with Grey and XS, which the customer never chose. The task says all fields are required. See line 31.
There's a stray </div> on line 56. It's the one error the HTML validator from the README checklist (https://validator.w3.org/) reports, and Prettier can't parse the file because of it.
Formatting. Once line 56 is fixed, run npx prettier --write Form-Controls from the repo root and push.

Add the Needs Review label again once you've pushed.

abdishakoor-dev · 2026-09-14T14:01:41Z

+        <!-- 1. What is the customer's name? I must collect this data and ensure it contains at least two non-space characters.-->
+         <div>
+        <label for="name">Name</label>
+        <input type="text" id="name" placeholder="Chandrmani Gaire" pattern=".*\S.*\S." required>


Compare this pattern with the one in the README character by character. The last part is different. What does a . on its own match, and how many characters does it require after the second non-space one?

type name=.\S.\S.* here

Fixed. A is rejected and AB goes through now.

abdishakoor-dev · 2026-09-14T14:01:41Z

+      <div>
+      <!--What colour should this T-shirt be? I must provide 3 options. How will I ensure they do not choose other colours? -->
+      <label for="coloroption">Color option</label>
+      <select id="coloroption" name="Color">


This select has no required, and because the first option is a real colour it's already "chosen" when the page loads. What would you add so the customer has to make a choice? Same for the size select on line 42. The MDN form validation page from the prep covers this.

put
on this section

Both dropdowns fixed. Good.

abdishakoor-dev · 2026-09-14T14:01:41Z

+          <input id="submit" type="submit">
+        </div>
+        <br>
+      </div>


Which <div> is this closing? Count the opening and closing divs above it.

clear the
like this

Fixed, validator is clean.

abdishakoor-dev · 2026-09-14T14:01:41Z

+      <br>
+      <div>
+      <label for="email">Email</label>
+        <input type="email" placeholder="chandramani@gmail.com" id="email" required>


The two selects have a name attribute but the name and email inputs don't. What does name do when a form is submitted? Try submitting and look at the address bar.

change the name="email"

abdishakoor-dev · 2026-09-14T14:01:41Z

    <footer>
      <!-- change to your name-->
-      <p>By HOMEWORK SOLUTION</p>
+      <p>  By Chandramani  Gaire</p>


Extra spaces before "By" and between your first and last name, and the starter comment on line 63 can go now.

change the space

Spaces fixed. The starter comment on line 62 is still there, see the main comment.

netlify · 2026-09-14T20:37:27Z

A new user left a comment. This user must be approved by a Netlify team owner before comments can be displayed.

Approve this user

netlify · 2026-09-14T20:41:52Z

A new user left a comment. This user must be approved by a Netlify team owner before comments can be displayed.

Approve this user

gaireprakash20-ops · 2026-09-15T22:03:21Z

thanks

abdishakoor-dev

Only one blank line changed in that push, so the formatting hasn't happened yet: Prettier still fails on index.html and the starter comment on line 61 is still there.

A quick way to tell whether it worked: after Format Document, the <input> on line 20 should be spread over several lines, one attribute per line, and every line inside <form> should sit two spaces further in than the one containing it. If nothing changes when you right click and choose Format Document, VS Code hasn't got Prettier: go to Extensions, search for CodeYourFuture Extension Pack, install it, then try again. If it asks which formatter to use, pick Prettier.

Save, check the file looks different, commit, push, and add Needs Review again.

gaireprakash20-ops

final one

abdishakoor-dev

The file is formatted now, you can see the difference in the input on lines 20 to 27 with one attribute per line. Good.

One thing left, and it's the third time of asking: the starter comment  on line 75. It was an instruction to you, you've followed it, so delete the line. Then push, add Needs Review, and I'll mark this Complete.

abdishakoor-dev · 2026-09-16T18:52:15Z

      </form>
    </main>
    <footer>
      <!-- change to your name-->


There is no need for this comment line, it can be removed.

gaireprakash20-ops

change the line 75

abdishakoor-dev

Everything on the list done. Marking this Complete. Well done.

gaireprakash20-ops · 2026-09-20T22:27:00Z

somthing goona wrong on my git account can you please help me

gaireprakash20-ops added 4 commits September 12, 2026 14:56

Fixed error in code.

c1b5342

corrected sizes

add submit and reset button

06f259f

adding the reset and put bracket on color

26ee31c

adding br space out the page

e5cb8dd

size

gaireprakash20-ops added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 1 Assigned during Sprint 1 of this module labels Sep 12, 2026

abdishakoor-dev reviewed Sep 14, 2026

View reviewed changes

abdishakoor-dev added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 14, 2026

gaireprakash20-ops added 7 commits September 14, 2026 21:53

space in name change

3c0daf7

div tag change

0e8d387

change email

8adacf3

add fieldset

919333d

change the name of color and size

69c63c1

change for on label of size

54cb7e7

change the size value in uppercase

09f4a5f

gaireprakash20-ops requested a review from abdishakoor-dev September 15, 2026 16:55

final submit

194abd4

abdishakoor-dev removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 15, 2026

final check

3bc4ca6

gaireprakash20-ops added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Sep 15, 2026

gaireprakash20-ops requested a review from abdishakoor-dev September 15, 2026 22:10

abdishakoor-dev reviewed Sep 16, 2026

View reviewed changes

abdishakoor-dev added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 16, 2026

gaireprakash20-ops added 2 commits September 16, 2026 19:01

formate change

c1a0239

final changes for formate

fb4ab7b

gaireprakash20-ops commented Sep 16, 2026

View reviewed changes

gaireprakash20-ops added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Sep 16, 2026

abdishakoor-dev reviewed Sep 16, 2026

View reviewed changes

abdishakoor-dev added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 16, 2026

gaireprakash20-ops added 2 commits September 16, 2026 19:56

line deleted

07f73f0

i only change the blank line

91e0c1a

gaireprakash20-ops commented Sep 16, 2026

View reviewed changes

gaireprakash20-ops added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Sep 16, 2026

abdishakoor-dev reviewed Sep 16, 2026

View reviewed changes

abdishakoor-dev added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 16, 2026

gaireprakash20-ops closed this Sep 20, 2026

gaireprakash20-ops deleted the Form-Controls branch September 20, 2026 22:03

gaireprakash20-ops restored the Form-Controls branch September 20, 2026 22:04

gaireprakash20-ops reopened this Sep 20, 2026

Uh oh!

Conversation

gaireprakash20-ops commented Sep 12, 2026

Learners, PR Template

Task code

Changelist

Uh oh!

netlify Bot commented Sep 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cyf-onboarding-module ready!

Uh oh!

abdishakoor-dev left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

netlify Bot commented Sep 14, 2026

Uh oh!

netlify Bot commented Sep 14, 2026

Uh oh!

gaireprakash20-ops commented Sep 15, 2026

Uh oh!

abdishakoor-dev left a comment

Choose a reason for hiding this comment

Uh oh!

gaireprakash20-ops left a comment

Choose a reason for hiding this comment

Uh oh!

abdishakoor-dev left a comment

Choose a reason for hiding this comment

Uh oh!

abdishakoor-dev Sep 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gaireprakash20-ops left a comment

Choose a reason for hiding this comment

Uh oh!

abdishakoor-dev left a comment

Choose a reason for hiding this comment

Uh oh!

gaireprakash20-ops commented Sep 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify Bot commented Sep 12, 2026 •

edited

Loading

abdishakoor-dev left a comment •

edited

Loading

abdishakoor-dev Sep 16, 2026 •

edited

Loading