London | 26 ITP MAY | Russom Gebremeskel | Sprint 2 | Coursework by russom-g · Pull Request #1502 · CodeYourFuture/Module-JavaScript-Fundamentals

russom-g · 2026-09-11T21:42:21Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Task code

CYF-1039

Changelist

Using documentations errors explained fixed. Program explained step by step.

netlify · 2026-09-11T21:42:27Z

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	`e9d4ba3`
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/6ab18f76b514ee00082b27e5
😎 Deploy Preview	https://deploy-preview-1502--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

webmonch · 2026-09-14T21:44:54Z

+
+// Answers
+
+// a) There are no function or function calls in this code.


How are functions usually invoked in JS?

In JS functions are invoked when the function's name is written followed by parentheses.

You answered this well in the thread: a function is called with its name and parentheses. Now use that on the file. Number(...) is a function call. What else on lines 4, 5 and 10 has a name followed by (...)? Please update answer a) on line 26.

webmonch · 2026-09-14T21:46:32Z

+
+// a) There are 6 variable declarations.
+
+// b) There are no function calls.


Similar question to the one I left in previous file

Is this question about variables or functions?

It is about functions. A function call is a name followed by (...). % and / are operators, not function calls. Is there any name followed by (...) in lines 1 to 10? Please update b) on line 31.

webmonch · 2026-09-14T21:47:58Z

 // Try logging the value of num and running the program several times to build an idea of what the program is doing
+
+// 1. num is a variable that stores the final result of the expression assigned to it.
+// 2. The Math.random() method generates a random decimal number from 0 up but not excluding 1.


Could be worth having another look at Math.random docs here.

Ok. I will.

The Math.random() method returns a pseudo-random floating number between 0(inclusive) and 1(exclusive).

Line 12 is right now. One thing is still missing. Your steps say how num is made, but not what it is. What is the smallest value num can be? And the largest? Add one line at the end that says what num is.

webmonch · 2026-09-14T21:49:12Z

-const dir = ;
-const ext = ;
+const dir = filePath.slice(0, lastSlashIndex);
+const ext = filePath.slice(-3);


Can you think of a more robust way to find extention?

It'a changed to const ext = filePath.slice(filePath.length -3)

filePath.slice(filePath.length - 3) gives the same result as slice(-3). It always takes the last 3 characters. Try it with photo.jpeg. You get peg, not jpeg.

The code on lines 13 and 14 already solves the same kind of problem for base:

Line 13 finds the position of the last / with lastIndexOf("/").

Line 14 slices from that position to the end.

The extension starts at the last . in the path. Can you do the same two steps, but with "." instead of "/"?

webmonch · 2026-09-14T21:51:39Z

@@ -1,9 +1,16 @@
 const cardNumber = 4533787178994213;
-const last4Digits = cardNumber.slice(-4);
+const last4Digits = Number(String(cardNumber).slice(-4));


Can you think of any edge cases that could surface here?

An cardNumber = "" can return empty string. cardNumber = 123 can return 123.

Your first version was very good: Number(String(cardNumber).slice(-4)). Now you changed line 1 into a string instead. But the exercise asks you to update the expression on line 2, and line 16 still talks about Number(). Please go back to your first version.

webmonch · 2026-09-14T21:56:27Z

+
+// c) The reminder (%) operator returns the reminder left over when one operand is divided by a second operand.
+
+// d) movieLength(8784) - remainingSeconds(24) = 8760(seconds). 8760 / 60 gives us 146 minutes. totalMInutes = 146


Nice! Great example of using real numbers to make explanation super clear.

Thanks for taking the time to review my code and give feedback.

webmonch · 2026-09-14T22:00:45Z

Good job! Very clear explanations/answers to most questions. Only few small bits to revisit here.

abdishakoor-dev

Your answers are clear and well explained. Your breakdown of line 4 in 2-time-format.js is very good, with real numbers at each step. 3-to-pounds.js step 3 also has good examples, with 11 and 1.

I have left a hint on each line. Please fix these things before I can mark this Complete:

1-percentage-change.js a) and 2-time-format.js b): both say there are no function calls. But both files have some. A function call is a function name followed by brackets, like name(...). For example, console.log(...) and Number(...) are function calls. Look for this pattern in each file, and count them again.
3-paths.js line 21: ext only works when the extension has 3 letters. The code on lines 13 and 14 shows you a better way. See my reply on line 21.
4-random.js: say what num is at the end.
2-mandatory-errors: 1.js has no explanation. 2.js and 4.js need the error type (SyntaxError, TypeError or ReferenceError). In 3.js, change line 2, not line 1.
2-time-format.js: answers c) and f).
"My changes follow the style guide" is on your checklist, and consistent formatting is part of it. The tool that does it is called Prettier. It sets spacing and indentation to one agreed style. Then a reviewer only sees the changes you meant to make. Right now all the files you changed fail that check.

Prettier comes with the CYF extension pack from onboarding. If you are not sure you have it, open VS Code, go to Extensions, and search for CodeYourFuture Extension Pack: https://marketplace.visualstudio.com/items?itemName=CodeYourFuture.cyf-extension-pack

Then open each file you changed, right click in the editor, and choose Format Document. Pick Prettier if VS Code asks. Save, commit and push. To format every time you save, follow the format on save steps here: https://github.com/CodeYourFuture/Module-JavaScript-Fundamentals/blob/main/practical_guide.md

Add the Needs Review label again once you have pushed.

abdishakoor-dev · 2026-09-23T15:42:54Z


-const age = 33;
+let age = 33;
 age = age + 1;


The fix works. But the exercise also asks you to explain the error. Please add a comment with the error type and the reason.

The prep shows three error types:

SyntaxError: the code breaks a rule of JavaScript, so no line runs.

TypeError: the code tries to do something that value cannot do.

ReferenceError: the code uses a variable it cannot reach.

When you ran the original file, node's error message started with one of these. Which one was it? And why does let fix it?

abdishakoor-dev · 2026-09-23T15:42:54Z

 const cityOfBirth = "Bolton";
+console.log(`I was born in ${cityOfBirth}`);
+
+// Java script cannot access the variable cityOfBirth before initialization.


Your reason is right, and the fix works. Please also write the error type.

The prep shows three error types:

SyntaxError: the code breaks a rule of JavaScript, so no line runs.

TypeError: the code tries to do something that value cannot do.

ReferenceError: the code uses a variable it cannot reach.

When you ran the original file, node's error message started with one of these. Which one was it?

abdishakoor-dev · 2026-09-23T15:42:54Z

+const twelveHourClockTime = "8:53pm";
+const twentyFourHourClockTime = "20:53";
+
+// Variable names cannot start with a number in Java Script.


Your reason is right, and the new names work. Please also write the error type.

The prep shows three error types:

SyntaxError: the code breaks a rule of JavaScript, so no line runs.

TypeError: the code tries to do something that value cannot do.

ReferenceError: the code uses a variable it cannot reach.

When you ran the original file, node's error message started with one of these. Which one was it?

abdishakoor-dev · 2026-09-23T15:42:54Z

+
+// b) There are no function calls.
+
+// c) The reminder (%) operator returns the reminder left over when one operand is divided by a second operand.


This is what % does in general. In this program, movieLength % 60 gives 24. Are those 24 seconds, minutes or hours? Write what the 24 means here.

abdishakoor-dev · 2026-09-23T15:42:54Z

+
+// e) result represents the length of the movie in hours, minutes, and seconds format. It can be renamed movieDuration.    
+
+// f) When displaying single digit hour, minute, or seconds it doesn't include 0 in front of the digit.


Good, that is one problem. Now try -90 and 90.5 as movieLength. What does the program print each time? Add what you see to f).

russom and others added 30 commits September 2, 2026 22:04

Update code from 26-ITP-MAY to 26 ITP-SEP for resubmitting

2d1b73d

validate error with w3.org

21df038

Lables and input and css created

2753312

Style seprated from html and contained in its own file.

56c0cf5

add regex to name label

148a95a

update name

406e215

update align author name centre

b9b3c99

link css file

a2f9b70

remove duplicate css file

06cd821

Centre submit button

05ec57a

Add css validation icon display

a6af01c

Describe line 3 code

e41c304

Update answer

d3a57b0

Implement charAt method

c302bc4

Create variable using slice method

e43b31e

Explain how the code works

9a013e1

Comment out non code comments

439f732

Reassign age variable

ed79f77

Initialize variable first

28e7901

Fix data type

50b1516

Fix variable name declaration

209739c

Answer question. Fix code. Add comma.

a613e4c

Answer question and explain.

fbade85

Explain how the program work

ee0394d

Explain code step by step.

b3f5ce4

Questions answered about alert and prompt on chrome

19404bf

Answer questions on console object

47c46d3

Format answers with numbers.

59a3ca0

Format answers with numbers.

171051e

Merge branch 'CodeYourFuture:main' into coursework/sprint-2

e0505a8

This comment has been minimized.

Sign in to view

Remove Form-Controls files from sprint-2 branch

329b172

russom-g added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 11, 2026

Refactor code by removing padEnd method

5a857cf

webmonch self-requested a review September 14, 2026 21:37

webmonch added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 14, 2026

webmonch reviewed Sep 14, 2026

View reviewed changes

webmonch added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Sep 14, 2026

russom added 3 commits September 16, 2026 21:21

Change to robust slice method

0a6358a

Change number type to string to make it work edge cases.

6f5e1ca

Update Math.random method description

e9d4ba3

russom-g added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Sep 23, 2026

abdishakoor-dev reviewed Sep 23, 2026

View reviewed changes

abdishakoor-dev added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 23, 2026


		// Answers

		// a) There are no function or function calls in this code.


		// a) There are 6 variable declarations.

		// b) There are no function calls.


		// c) The reminder (%) operator returns the reminder left over when one operand is divided by a second operand.

		// d) movieLength(8784) - remainingSeconds(24) = 8760(seconds). 8760 / 60 gives us 146 minutes. totalMInutes = 146


		// e) result represents the length of the movie in hours, minutes, and seconds format. It can be renamed movieDuration.

		// f) When displaying single digit hour, minute, or seconds it doesn't include 0 in front of the digit. No newline at end of file

Uh oh!

Conversation

russom-g commented Sep 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Task code

Changelist

Uh oh!

netlify Bot commented Sep 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cyf-onboarding-module ready!

Uh oh!

This comment has been minimized.

This comment has been minimized.

Choose a reason for hiding this comment

Uh oh!

russom-g Sep 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

webmonch commented Sep 14, 2026

Uh oh!

abdishakoor-dev left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

russom-g commented Sep 11, 2026 •

edited

Loading

netlify Bot commented Sep 11, 2026 •

edited

Loading

russom-g Sep 16, 2026 •

edited

Loading