Conversation
Log the recipe title, servings, and each ingredient on a new line.
Add validation to ensure 'contains' function receives a valid object.
Added tests for createLookup function to verify its behavior with multiple country currency pairs, single pairs, empty input, and duplicate country codes.
Refactor createLookup to accept countryCurrencyPairs as an argument and return a lookup object.
Enhance query string parsing to handle empty pairs and decode components.
Removed tests for handling identical keys in query strings.
Implement tally function to count occurrences of items.
Fix the implementation of the invert function to correctly swap keys and values.
Add unit tests for the invert function to verify its behavior with various inputs.
mrafeie
added
📅 Sprint 2
LonMcGregor
reviewed
Sep 22, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Generally looks good, however did you run the tests before submitting? I see some that fail in one task.
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Task code
CYF-1083
Changelist
Sprint 2 exercises
Questions