Convert a stream to a byte array: retarget net10.0, add ReadExactly, CopyTo and the reverse direction - #2219
Open
vladimir-pecanac-main wants to merge 1 commit into
Conversation
…CopyTo and the reverse direction Retargets both projects from net7.0 to net10.0 and moves the packages to current stable versions (BenchmarkDotNet 0.15.8, Microsoft.NET.Test.Sdk 18.10.1, xunit 2.9.3, xunit.runner.visualstudio 4.0.0, coverlet.collector 10.0.1). Adds UseReadExactly() and UseCopyTo() to ConvertStreamToByteArray, which are the two calls the article now recommends, and UseMemoryStreamConstructor() and UseWritableMemoryStream() for the reverse direction. Four xunit tests cover them, and UseReadExactly and UseCopyTo also join ConvertMethodsBenchmark so the published benchmark measures the recommended methods. Build is clean and tests run 9 of 9 on SDK 10.0.302.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the sample behind https://code-maze.com/create-byte-array-from-stream-in-csharp/.
Both projects move from net7.0 to net10.0. Packages go to current stable: BenchmarkDotNet 0.15.8, Microsoft.NET.Test.Sdk 18.10.1, xunit 2.9.3, xunit.runner.visualstudio 4.0.0, coverlet.collector 10.0.1. xunit stays the test framework for this folder.
New code:
Verified on SDK 10.0.302 against runtime 10.0.10: dotnet build -c Release is 0 errors and 0 warnings, dotnet test is 9 of 9 passing, and the full DefaultJob benchmark run completes with UseReadExactly fastest at 350.3 us and 718.14 KB allocated.
Only this article's folder is touched.