Comma-separated string from a list: retarget net10.0, add generic and char-separator overloads - #2214
Open
vladimir-pecanac-main wants to merge 1 commit into
Conversation
… char-separator overloads Retarget both projects from net6.0 to net10.0 and bump the test packages (Microsoft.NET.Test.Sdk 18.10.1, xunit 2.9.3, xunit.runner.visualstudio 4.0.0, coverlet.collector 10.0.1). Add two samples the article needs: string.Join over a List<int>, which the generic overload handles without a Select, and the char separator overload. Two matching facts cover them. Drop the new-console-template comment and lift the test file to a file-scoped namespace and a collection expression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retargets both projects in strings-csharp/CreateCommaSeparatedStringFromListOfString from net6.0 to net10.0 and bumps the test packages to Microsoft.NET.Test.Sdk 18.10.1, xunit 2.9.3, xunit.runner.visualstudio 4.0.0 and coverlet.collector 10.0.1.
Adds two samples the article needs: string.Join over a List, which the generic overload handles without a Select, and the char separator overload. Two matching facts cover them.
Drops the new-console-template comment and lifts the test file to a file-scoped namespace and a collection expression.
Build succeeded with 0 warnings and 0 errors; 5 of 5 tests pass on SDK 10.0.302, runtime 10.0.10.