Task.CompletedTask vs Task.FromResult vs return: retarget to net10.0 and drop the redundant async - #2208
Open
vladimir-pecanac-main wants to merge 1 commit into
Conversation
…op redundant async, add notification handler example - Retarget both projects from net7.0 to net10.0 - Bump Microsoft.NET.Test.Sdk to 18.10.1, xunit to 2.9.3, xunit.runner.visualstudio to 4.0.0, coverlet.collector to 10.0.1 - UseTaskFromResultAsync() drops async/await and returns Task.FromResult(message) directly - Remove UseTaskCompletedSync() and UseTaskFromResultSync(), and their calls in Program.cs - Add INotificationHandler and ConsoleNotificationHandler, the imposed-signature case for Task.CompletedTask - Add two tests asserting both factory-returned tasks are already complete without being awaited
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates async-csharp/TaskCompletedTaskFromResultVsReturnInCSharp for the article rewrite.
Build: 0 errors, 0 warnings. Tests: 5 of 5 passing on SDK 10.0.302 / runtime 10.0.10.