MemoryStream in C#: net10.0 retarget, xunit 2.9.3, Person as a record, Assert.Equal - #2203
Open
vladimir-pecanac-main wants to merge 1 commit into
Open
vladimir-pecanac-main wants to merge 1 commit into
vladimir-pecanac-main wants to merge 1 commit into
Conversation
…ert.Equal Retarget both projects from net7.0 to net10.0. Test packages: Microsoft.NET.Test.Sdk 16.11.0 to 18.10.0, xunit 2.4.1 to 2.9.3, xunit.runner.visualstudio 2.4.3 to 4.0.0, coverlet.collector 3.1.0 to 10.0.1. Person becomes a positional record, which removes the two CS8618 warnings on its non-nullable string properties. DeserializeObject constructs it positionally, and C# evaluates arguments left to right, which is the order BinaryReader needs. Seven Assert.True calls in MethodsTests become Assert.Equal, clearing the xUnit2010 warnings the 2.9.3 analyzer raises. Build: 0 warnings, 0 errors. Tests: 10 of 10 passing on SDK 10.0.302, runtime 10.0.10. The console app output is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the
csharp-intermediate-topics/MemoryStreamInCsharpsample alongside a rewrite of the matching article.net7.0tonet10.0.Microsoft.NET.Test.Sdk16.11.0to18.10.0,xunit2.4.1to2.9.3,xunit.runner.visualstudio2.4.3to4.0.0,coverlet.collector3.1.0to10.0.1.Personbecomes a positional record, which clears the two CS8618 warnings on its non-nullable string properties.DeserializeObject()constructs it positionally, and C# evaluates arguments left to right, which is the orderBinaryReaderneeds.Assert.True(x.Equals(y))calls inMethodsTestsbecomeAssert.Equal(y, x), clearing the xUnit2010 warnings the 2.9.3 analyzer raises.