MapControllers vs MapControllerRoute: retarget to net10.0, refresh test stack - #2197
Merged
Conversation
…st stack - Both projects move from net8.0 to net10.0. - Test packages: Microsoft.AspNetCore.Mvc.Testing 10.0.12, Microsoft.NET.Test.Sdk 18.10.0, xunit 2.9.3, xunit.runner.visualstudio 4.0.0, coverlet.collector 10.0.1. - Remove the no-op <InternalsVisibleTo Include="Tests" /> from Tests.csproj: it named the test project itself, and both tests drive the app through WebApplicationFactory and HTTP. - Remove seven leftover _ContentIncludedByDefault Remove= entries naming view files that no longer exist in the folder. - Null-conditional on ContentType in ConventionIntegrationTest, which fixes the CS8602 the retarget surfaces under <Nullable>enable</Nullable>. Build clean with 0 warnings, 9 of 9 tests pass on SDK 10.0.302 / runtime 10.0.10.
…ontrollerroute-routing
…ontrollerroute-routing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retargets the
aspnetcore-features/MapControllersMapControllerRouteSlnsample to .NET 10 and refreshes its test stack.net8.0tonet10.0.<InternalsVisibleTo Include="Tests" />fromTests.csproj. It named the test project itself, and both tests drive the application throughWebApplicationFactoryand HTTP, so nothing needed it._ContentIncludedByDefault Remove=entries naming view files that are no longer in the folder.ContentTypeinConventionIntegrationTest, which clears the CS8602 the retarget surfaces under<Nullable>enable</Nullable>.Build is clean with 0 warnings and 9 of 9 tests pass on SDK 10.0.302 / runtime 10.0.10. No behaviour change: all nine routes the two integration tests cover still answer as before.